Setup sysdig scanning in CI#1416
Conversation
This is a trial run for ITS
It's a variable at the org-level, not a secret
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
FYI @shannon-m-johnston & @RVNOAA. Seems like it worked! I'll check our sysdig portal in the morning. You can view the diff ("Files Changed" tab) to see what I changed for my pipeline here. |
|
We can see the scan results from Github by jumping into the pipeline. (E.g. https://github.com/NOAA-GSL/MATS/actions/runs/28565792152) I'm probably going to need to tweak the configuration to get CI to work the way we'd like. Results show up in the portal like so: https://us2.app.sysdig.com/secure/#/vulnerabilities/results/18be5f9af2904fd86bcc1de948a525a0/overview |
This should reduce duplicate findings
Right now we're still evaluating Sysdig, so let the pipeline pass if the scan fails.
|
@mollybsmith-noaa - GSL has a new security scanner that we're evaluating. I've set it up in the MATS pipelines alongside Trivy so that we can check it out. I set it up in "informational" mode - it won't fail CI if the scan fails. If we adopt the scanner going forward, we'll want to change that. I'm hoping its output will provide better feedback on what it's detected than Trivy. It looks like it drops its feedback in the CI job "Summary" tab. (https://github.com/NOAA-GSL/MATS/actions/runs/28606734894?pr=1416) The per-layer breakdown of the image is particularly helpful - Trivy just tells you that it found issues in the image as a whole, and I've then had to go try to figure out which part of the image they're coming from. I also appreciate that it lists the vulnerabilities in the CI output - Trivy makes you hunt for them elsewhere in Github. |
mollybsmith-noaa
left a comment
There was a problem hiding this comment.
Sorry to be slow, this looks good to me!
|
No worries! You definitely weren't slow. It'll be interesting to see how this shapes up as it migrates towards the |
Setup the Sysdig CI scanner alongside Trivy in the MATS CI pipelines so that we can evaluate it. I set the Sysdig scanner up in "informational" mode - it won't fail CI if the scan fails. If we adopt the scanner going forward, we'll want to change that.