Skip to content

Remove empty .gitmodules - #41

Merged
fmalatino merged 1 commit into
NOAA-GFDL:mainfrom
romanc:romanc/remove-empty-gitmodules
Jul 8, 2026
Merged

Remove empty .gitmodules#41
fmalatino merged 1 commit into
NOAA-GFDL:mainfrom
romanc:romanc/remove-empty-gitmodules

Conversation

@romanc

@romanc romanc commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

A file called .gitmodules is usually used to store informations about git subodules. It appears that pyFMS has no submodules. It is thus unucessary - and imo confusing - to keep an empty .gitmodules file around.

This is a follow-up from #39, which moved the cFMS dependency from a submodule to be pulled via CMakeList.txt.

How Has This Been Tested?

If pyFMS was relying on submodules to be installed (it is not), CI would fail.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

A file called `.gitmodules` is usually used to store informations about
`git` subodules. It appears that `pyFMS` has no submodules. It is thus
unucessary - and imo confusing - to keep an empty `.gitmodules` file
around.
@romanc romanc changed the title Remove empty .gitmodules Remove empty .gitmodules Jul 8, 2026
@fmalatino
fmalatino merged commit 5695921 into NOAA-GFDL:main Jul 8, 2026
2 checks passed
@romanc
romanc deleted the romanc/remove-empty-gitmodules branch July 27, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants