refactor: avoid quantity.data in favor of direct getter/setter#195
Open
romanc wants to merge 1 commit into
Open
refactor: avoid quantity.data in favor of direct getter/setter#195romanc wants to merge 1 commit into
quantity.data in favor of direct getter/setter#195romanc wants to merge 1 commit into
Conversation
Collaborator
Author
|
@twicki can't put you as a reviewer on this one (don't know why, but not in the dropdown 🤷) |
Contributor
|
Thanks for the ping, will have a look |
Calling `.data` on a quanity is deprecated and the functionality is about to be removed in future versions of NDSL. This PR makes a pass over pace removing/replacing references to `quantity.data` with direct getters and setters.
romanc
force-pushed
the
romanc/avoid-quantity-dot-data
branch
from
July 22, 2026 13:06
1ea15d7 to
f5c56f3
Compare
Collaborator
|
Happy to merge if @twicki is ok with it |
Collaborator
Author
Thanks 🙏 Tobias will be back tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calling
.dataon a quanity is deprecated and the functionality is about to be removed in future versions of NDSL. This PR makes a pass over pyFV3 removing replacing references toquantity.datawith direct getters and setters.How Has This Been Tested?
Covered by CI, I guess - at least partly.
Checklist: