Updating NullComm to support boundary condition ingest methods in NDSL - #194
Open
fmalatino wants to merge 2 commits into
Open
Updating NullComm to support boundary condition ingest methods in NDSL#194fmalatino wants to merge 2 commits into
NullComm to support boundary condition ingest methods in NDSL#194fmalatino wants to merge 2 commits into
Conversation
6 tasks
oelbert
approved these changes
Jul 23, 2026
oelbert
left a comment
oelbert
left a comment
Collaborator
There was a problem hiding this comment.
This is fine, but what are we using this for? I think NullComms should be used sparingly for very rudimentary tests and I'm not sure BCs are quite simple enough for that lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a method to
NullCommto support the introduction of theScattervmethod used for boundary condition ingest inNDSLHow Has This Been Tested?
Current CI
Checklist: