add diag_manager output option#192
Open
rem1776 wants to merge 28 commits into
Open
Conversation
…tion method to diag_table
rem1776
marked this pull request as ready for review
July 21, 2026 19:05
FlorianDeconinck
left a comment
Collaborator
There was a problem hiding this comment.
This is looking good - including the changes from mpich to openmpi.
My only worries is order of merge of open PR with the NDSL/pySHiELD. @oelbert to check and sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this needs NOAA-GFDL/NDSL#485 in first so is a draft for now.
This PR adds "diag_manager" as an output option for the diagnostics config, as well as adding pyFMS as an optional dependency.
When the output format is used it will initialize pyFMS and set up it's domain decomposition, and then output diagnostics via the fortran library. This allows for buffering the data prior to writing and performing reductions such as average, min/max, etc over a set number of timesteps.
I added an example diag_table.yaml which is used to change what is output, such as adding new variables, files, or reductions. Its currently set up for the accompanying
baroclinic_c12_diag_manager.yamlconfig to output the model state as well as some 'reduced' fields such as the average temperature over the course of the run.I want to note that the 'diag_manager' option will require both
diag_table.yamlandinput.nmlto be in the current working directory when pace is run. The input.nml will be created when the option in used, but the diag_table.yaml will need to be provided in the working directory when pace is run.How Has This Been Tested?
tested with the added
baroclinic_c12_diag_manager.yamlconfiguration, along with the added diag_table.yaml.Checklist: