Skip to content

Update validate_script.py to check for circular workflow graphs - #940

Open
ilaflott wants to merge 1 commit into
mainfrom
106-fre-pp-validate-doesnt-check-for-circular-dependencies-in-large-workflows
Open

Update validate_script.py to check for circular workflow graphs#940
ilaflott wants to merge 1 commit into
mainfrom
106-fre-pp-validate-doesnt-check-for-circular-dependencies-in-large-workflows

Conversation

@ilaflott

Copy link
Copy Markdown
Member

Describe your changes

Issue ticket number and link (if applicable)

Fixes #XXX (replace XXX with the issue number and GitHub will autolink the PR to the issue)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.09%. Comparing base (ad94447) to head (22f6603).

Files with missing lines Patch % Lines
fre/pp/validate_script.py 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          67       67           
  Lines        3736     3736           
=======================================
  Hits         3067     3067           
  Misses        669      669           
Flag Coverage Δ
unittests 82.09% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fre/pp/validate_script.py 18.18% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad94447...22f6603. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilaflott
ilaflott requested review from ceblanton and singhd789 July 15, 2026 20:33
@ilaflott
ilaflott marked this pull request as ready for review July 15, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fre pp validate (near future: fre workflow validate) doesn't check for circular dependencies in large workflows

1 participant