Skip to content

871.list yamls tool - #933

Open
singhd789 wants to merge 23 commits into
NOAA-GFDL:mainfrom
singhd789:871.list-yamls-tool
Open

871.list yamls tool#933
singhd789 wants to merge 23 commits into
NOAA-GFDL:mainfrom
singhd789:871.list-yamls-tool

Conversation

@singhd789

@singhd789 singhd789 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

Create fre list yamls subtool:

  • lists yamls listed in the model yaml to combine into one, resolved yaml config
  • returns a comma separated list so it can potentially be piped to fre yamltools combine (uw tools integration)
  • spits out warning for yamls that dont exist
  • Updated documentation and tried to make inline script doc compatible with how the fre-cli chatbot reads
  • if no experiment name is given --> it returns the model, compile, and platform yamls
  • if an experiment name is given, the default behavior is to return ALL, yamls associated with the experiment (model, compile, platform, settings, pp, analysis yamls)

Issue ticket number and link (if applicable)

Fixes #871

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.36%. Comparing base (3c5a980) to head (45fe77b).

Files with missing lines Patch % Lines
fre/list_/frelist.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
+ Coverage   82.09%   82.36%   +0.27%     
==========================================
  Files          67       68       +1     
  Lines        3736     3799      +63     
==========================================
+ Hits         3067     3129      +62     
- Misses        669      670       +1     
Flag Coverage Δ
unittests 82.36% <98.43%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fre/list_/list_experiments_script.py 100.00% <100.00%> (ø)
fre/list_/list_yamls_script.py 100.00% <100.00%> (ø)
fre/list_/frelist.py 86.20% <90.00%> (+1.99%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5a980...45fe77b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@singhd789 singhd789 linked an issue Jul 7, 2026 that may be closed by this pull request
Dana Singh and others added 5 commits July 7, 2026 12:03
@singhd789
singhd789 marked this pull request as ready for review July 17, 2026 18:11
@singhd789
singhd789 requested review from Ciheim, ceblanton and mlee03 July 20, 2026 21:15
Comment thread fre/list_/frelist.py Outdated
Comment thread fre/list_/frelist.py Outdated
Comment thread fre/list_/list_experiments_script.py Outdated
Comment thread fre/list_/README.md Outdated
Comment thread fre/list_/list_yamls_script.py Outdated
Comment thread fre/list_/list_yamls_script.py Outdated
"""
List_yamls_script provides methods to list and return YAML configurations to be combined into
one, resolved configuration. Different click options are avaiable to return only relevant yamls
depending on the process the user wants to run (compile, runtime, postprocess, analysis).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would explicit examples be more helpful?
Or adding info about when this tool is or could be used?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the examples would be in the quickstart right? Unless you think more examples should go here.

I added to the description for use cases of the subtool though! Good suggestion, thanks.

@singhd789
singhd789 requested a review from mlee03 July 21, 2026 15:15
@singhd789
singhd789 requested a review from ilaflott July 22, 2026 18:18

@ilaflott ilaflott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's basically ready for approval and merging post comments

Comment thread fre/list_/tests/test_list_yamls_script.py
Comment thread fre/list_/README.md Outdated
@singhd789

Copy link
Copy Markdown
Contributor Author

@mlee03 @ilaflott I hear your suggestions for output for the readme examples, haha. I'll add it in since it's desired

@singhd789

singhd789 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

ANOTHER NOTE: This fre list yamls subtool is kind of the first installment of yaml format changes!! So this fre list yamls subtool will only work with certain model yaml changes. I will open a subsequent issue to update all fre list test yamls to reflect these changes. This PR will be followed by the uw tools integration that will implement these changes as well

Update: here's the issue #955

@singhd789
singhd789 requested a review from ilaflott July 23, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create subtool to list desired yamls to combine

3 participants