871.list yamls tool - #933
Conversation
- lists yamls to be combined and passed to uw config tools
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
==========================================
+ Coverage 82.09% 82.36% +0.27%
==========================================
Files 67 68 +1
Lines 3736 3799 +63
==========================================
+ Hits 3067 3129 +62
- Misses 669 670 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…to 871.list-yamls-tool
- return a space separated string to pass to fre yamltools combine (uw tools) - update comments - provide warning for yamls that don't exist
…d789/fre-cli into 871.list-yamls-tool
| """ | ||
| List_yamls_script provides methods to list and return YAML configurations to be combined into | ||
| one, resolved configuration. Different click options are avaiable to return only relevant yamls | ||
| depending on the process the user wants to run (compile, runtime, postprocess, analysis). |
There was a problem hiding this comment.
Would explicit examples be more helpful?
Or adding info about when this tool is or could be used?
There was a problem hiding this comment.
I think the examples would be in the quickstart right? Unless you think more examples should go here.
I added to the description for use cases of the subtool though! Good suggestion, thanks.
ilaflott
left a comment
There was a problem hiding this comment.
it's basically ready for approval and merging post comments
|
ANOTHER NOTE: This fre list yamls subtool is kind of the first installment of yaml format changes!! So this fre list yamls subtool will only work with certain model yaml changes. I will open a subsequent issue to update all fre list test yamls to reflect these changes. This PR will be followed by the uw tools integration that will implement these changes as well Update: here's the issue #955 |
…to 871.list-yamls-tool
Describe your changes
Create
fre list yamlssubtool:fre yamltools combine(uw tools integration)Issue ticket number and link (if applicable)
Fixes #871
Checklist before requesting a review
Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the
release_procedure.mdtemplate. To quickly use this template, open a new pull request, choose your branch, and add?template=release_procedure.mdto the end of the url.