Skip to content

Fix test issue caused by previously cloned fre-workflows - #899

Open
ceblanton wants to merge 2 commits into
mainfrom
898.checkout-test-fix
Open

Fix test issue caused by previously cloned fre-workflows#899
ceblanton wants to merge 2 commits into
mainfrom
898.checkout-test-fix

Conversation

@ceblanton

@ceblanton ceblanton commented May 22, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

Three seemingly independent fixes suggested by claude:

  1. Add pytest configuration to forbid recursing into the 'configure_yaml_out' directory
  2. In test_configure_script_yaml.py, restore HOME even if the test fails
  3. In test_fre_pp_cli.py, remove the checked-out directory after the test (as well as before)

Issue ticket number and link (if applicable)

Fixes #898

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

Three seemingly independent fixes suggested by claude:
1. Add pytest configuration to forbid recursing into the 'configure_yaml_out' directory
2. In test_configure_script_yaml.py, restore HOME even if the test fails
3. In test_fre_pp_cli.py, remove the checked-out directory after the test (as well as before)
@ceblanton
ceblanton requested review from ilaflott and singhd789 May 22, 2026 19:31
@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.09%. Comparing base (ad94447) to head (54717d1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          67       67           
  Lines        3736     3736           
=======================================
  Hits         3067     3067           
  Misses        669      669           
Flag Coverage Δ
unittests 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad94447...54717d1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i prefer the previous approach, testing code should be rigid, not flexible

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same problem

Comment thread pyproject.toml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix test issue caused by previously cloned fre-workflows

2 participants