Add fill flag - #893
Conversation
|
Addresses #892 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=======================================
Coverage 82.09% 82.09%
=======================================
Files 67 67
Lines 3736 3737 +1
=======================================
+ Hits 3067 3068 +1
Misses 669 669
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
| #, help = 'Specify output filename suffix only. e.g. catalog') | ||
| @click.option('--config', required = False, type = click.Path(exists = True), nargs = 1, | ||
| help = 'Path to your yaml config, Use the config_template in intakebuilder repo') | ||
| @click.option('--fill', '-f', default=True, type=bool, help="Fill all empty CSV column values with 'NA'. Defaults to True. Use --fill=False to disable.") |
There was a problem hiding this comment.
To negate the fill option, it's more standard to make it a flag and let it be negated with --no-fill than require an value for the fill option --fill=False.
ceblanton
left a comment
ceblanton
left a comment
There was a problem hiding this comment.
This is ready for the same click updates that went into NOAA-GFDL/CatalogBuilder#159.
Also, please update meta.yaml and enviroment.yaml to specify the new catalogbuilder version. I think it's set to 2025.xx now.
|
@Ciheim how do you feel about this PR? |
|
Thought this one was already merged @ilaflott Thanks for the reminder. It's mostly ready to go. Just one more update and it should be good. |
3 participants
Describe your changes
Issue ticket number and link (if applicable)
Fixes #XXX (replace XXX with the issue number and GitHub will autolink the PR to the issue)
Checklist before requesting a review
Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the
release_procedure.mdtemplate. To quickly use this template, open a new pull request, choose your branch, and add?template=release_procedure.mdto the end of the url.