build fixes for fregrid-gpu#413
Open
rem1776 wants to merge 2 commits into
Open
Conversation
mlee03
approved these changes
Jul 24, 2026
| } | ||
| } | ||
| #pragma acc data update device(the_rotation_matrix_gpu[:3][:3]) | ||
| #pragma acc update device(the_rotation_matrix_gpu[:3][:3]) |
Contributor
There was a problem hiding this comment.
oh interesting. looking at the openacc api's, your change is the correct way to use update. Wonder why it didn't error out before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes to get the gpu build working. NVHPC just needed some include paths added. The rest of the changes are for GCC, rewrote the configure check and made some small code changes.
Fixes #412
How Has This Been Tested?
nvhpc 25.3 on the amd box and gcc 14.3 on my workstation.
Checklist:
make distcheckpasses