[WIP] feat(edm): implement EDM model families, R-level user workflows, and documentation - #1679
Open
aman-raj-srivastva wants to merge 1 commit into
Open
Conversation
… stubs Introduces `R/edm.R` with fully documented roxygen2 skeletons for the primary user-facing EDM functions. - `fit_edm()`: high-level wrapper for configuring and fitting Simplex, S-Map, and GP-EDM models using a `FIMSFrame` and delay embedding configuration. - `edm_forecast()`: high-level interface for generating empirical forecasts from a fitted `EDMFit` object. Both functions include complete parameter documentation, `@seealso` cross-references, and example usage to establish the public R API.
aman-raj-srivastva
force-pushed
the
feature/edm-user-workflows
branch
from
August 1, 2026 22:39
a8c12d0 to
2ef911f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Building upon the previously merged delay embedding infrastructure (#1528), prediction framework (#1561), and FIMS/TMB integration (#1620), this PR focuses on delivering high-level R interfaces, EDM model family abstractions, expanded R test coverage, and user documentation for Empirical Dynamic Modeling (EDM) within FIMS.
Goals
This PR focuses on:
Planned Changes
High-Level R Interface
Introduce user-facing wrapper functions that simplify running EDM models without directly interacting with low-level C++ interface objects.
Proposed API
These wrappers will build upon the existing EDM prediction framework while providing a simpler interface for fisheries scientists.
EDM Model Families
Implement reusable abstractions for:
These abstractions will reuse the prediction framework implemented in #1561 and the FIMS integration introduced in #1620.
Integration with FIMS
Provide higher-level workflows demonstrating how EDM predictions can be used within existing FIMS stock assessment pipelines.
Example use cases include:
Testing
Expand
testthatcoverage for:Documentation
This PR will include:
roxygen2documentation for exported R functions.The complete end-to-end EDM vignette (
vignettes/edm-user-guide.Rmd) will be delivered in a follow-up PR once the R interfaces are finalized and reviewed.Expected Outcome
After this work is complete, users will be able to:
Checklist
fit_edm(),edm_forecast())testthatcoverageroxygen2documentationRelated
Instructions for code reviewer
👋Hello reviewer👋, thank you for taking the time to review this PR!
nit:(for nitpicking) as the comment type. For example,nit:I prefer using adata.frame()instead of amatrixbecause ...This PR is now ready to be merged.Checklist