Make fims::Vector out-of-bounds errors actionable with vector identity, index, and size - #1667
Draft
Andrea-Havron-NOAA with Copilot wants to merge 2 commits into
Draft
Make fims::Vector out-of-bounds errors actionable with vector identity, index, and size#1667Andrea-Havron-NOAA with Copilot wants to merge 2 commits into
fims::Vector out-of-bounds errors actionable with vector identity, index, and size#1667Andrea-Havron-NOAA with Copilot wants to merge 2 commits into
Conversation
4 tasks
Copilot
AI
changed the title
[WIP] Improve fims::Vector out of bounds error message
Make Jul 28, 2026
fims::Vector out-of-bounds errors actionable with vector identity, index, and size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fims::Vectorbounds failures currently return a generic message, which makes it hard to identify the offending vector in model wiring. This updates vector metadata and error formatting so out-of-bounds exceptions point directly to the source and failing index.fims::Vectorerror payload improvementsvariable_name_mtofims::Vectorwithset_variable_name()/get_variable_name().operator[]overloads (const and non-const) to throw:Rcpp object wiring now names vectors at construction
set_variable_name(...)on vectors created/populated in:rcpp_models.hpp.Recruitment.<id>.log_devs,Fleet.<id>.log_Fmort), so errors align with registered parameter names.Focused coverage for new diagnostics
fims::Vector::operator[]bounds exceptions (const + non-const).