Refactor remaining interface scalar config fields to plain C++ types - #1659
Draft
Andrea-Havron-NOAA with Copilot wants to merge 5 commits into
Draft
Refactor remaining interface scalar config fields to plain C++ types#1659Andrea-Havron-NOAA with Copilot wants to merge 5 commits into
Andrea-Havron-NOAA with Copilot wants to merge 5 commits into
Conversation
6 tasks
Copilot
AI
changed the title
[WIP] Refactor scalar fields in interface classes to plain C++ types
Refactor remaining interface scalar config fields to plain C++ types
Jul 22, 2026
Andrea-Havron-NOAA
changed the base branch from
main
to
refactor-Rcpp-interface-S4-toXPtr
July 22, 2026 23:59
Collaborator
Contributor
Author
Applied the requested cherry-picks on this branch as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the remaining Rcpp interface classes in scope for Step 1 to stop storing scalar configuration values in
SharedPrimitivewrappers. The change aligns fleet, recruitment, growth, and distribution interfaces with the migrated population pattern by using plain C++ scalar fields and removing wrapper-style access at interface boundaries.Fleet interface
nameobserved_landings_unitsobserved_index_unitsRecruitment interface
process_idand Beverton-Holtn_yearswith plain integers.SetRecruitmentProcessID()andadd_to_fims_tmb_internal()to stop using.get()/.set().Growth interface
n_yearswith a plain integer.make_map(), JSON serialization, and TMB wiring to use direct scalar access.Distribution interfaces
input_type_muse_mean_minterface_observed_data_id_mnotesR interface compatibility updates
n_years <- ...instead ofn_years$set(...)).