Fix missing whitespace in log_M size mismatch error message - #1346
Merged
Conversation
5 tasks
Co-authored-by: Andrea-Havron-NOAA <85530309+Andrea-Havron-NOAA@users.noreply.github.com> Agent-Logs-Url: https://github.com/NOAA-FIMS/FIMS/sessions/a7489e2b-9488-42b1-ba55-ff062157642f
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on scalar log_M handling in catch-at-age output
Fix missing whitespace in log_M size mismatch error message
Mar 23, 2026
Andrea-Havron-NOAA
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjacent string literals in the
throw std::invalid_argumentcall were concatenated without a space, producing an unreadable message like"mismatch.Population log_M is of size...".Change
rcpp_population.hppso the message reads"Population log_M size mismatch. Population log_M is of size ...".Existing test regexp
"Population log_M size mismatch"continues to match without modification.⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.