-
Notifications
You must be signed in to change notification settings - Fork 14
Add neopdf PDF interpolation backend
#2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Radonirinaunimi
wants to merge
10
commits into
master
Choose a base branch
from
neopdf-backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b769a93
Init `neopdf` backend implementation
Radonirinaunimi 506fa3a
Fix exception handling
Radonirinaunimi 1b1eec8
Add `neopdf` as an optional dependency for the time being
Radonirinaunimi 8e629e1
Set `neopdf` version
Radonirinaunimi 8e3c7cf
Address most of review comments
Radonirinaunimi f9a0ff7
Point `neopdf` at the LHAPDF data directory
Radonirinaunimi 0a67489
Set `neopdf` as default instead of `nolha`
Radonirinaunimi d8fd15f
Define the PDF interpolation backend in the `nnprofile`
Radonirinaunimi c4093ad
Re-organize the interface
Radonirinaunimi 7fa4673
Add a separate action to set the `NEOPDF_DATA_PATH`
Radonirinaunimi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: Set NEOPDF_DATA_PATH | ||
|
|
||
| # Point NeoPDF at the directory where lhapdf-management stores PDF sets, | ||
| # so it reads local files instead of downloading from the LHAPDF servers. | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Point NeoPDF at the LHAPDF data directory | ||
| shell: bash -l {0} | ||
| run: | | ||
| echo "NEOPDF_DATA_PATH=$(python -c 'from lhapdf_management.configuration import environment; print(environment.datapath)')" >> $GITHUB_ENV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, to get the information from the profile just
get_nnpdf_profile()is enough (fromnnpdf_data::utils)I'm not sure right now whether one can add variables at will without changing that function (in any case it would be trivial). The important thing is, don't add a new default to
get_nnpdf_profileforpdf_backendbut rather add explicitly tovalidphys/nnprofile_default.yamlpdf_backend: lhapdf.The goal I have in mind is that people can start using
neopdfthere if they like and in a few months we try to swap the default and see what happens.