fix(macos): clear ALL xattrs on install (provenance, not just quarantine)#24
Merged
Conversation
…ine) The previous fix stripped only com.apple.quarantine. macOS sometimes also attaches com.apple.provenance during a curl download, which SIGKILLs the binary on first launch — even after quarantine is gone. That's the SIGKILL users see on `curl … | bash` when the script reaches `"$dest" --install --yes`. - install.sh: replace `xattr -d com.apple.quarantine` with `xattr -c` to clear every extended attribute the OS attached during download. - internal/install/install.go: same fix for the .app bundle path (`xattr -dr com.apple.quarantine` → `xattr -cr`). The Go toolchain already ad-hoc signs the binary at build time, so we don't need to invoke `codesign` ourselves — that would add a tooling dependency the install path shouldn't rely on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous Gatekeeper workaround in `install.sh` only stripped `com.apple.quarantine`. macOS sometimes also attaches `com.apple.provenance` during a curl download, which SIGKILLs the binary on first launch — even after quarantine is gone. That's what users see when `curl … | bash` reaches the trailing `"$dest" --install --yes` and dies.
```
==> Updating VibeCockpit unknown → v0.15.0
==> Installed v0.15.0 to /Users/jannasch/.local/bin/vibecockpit
bash: line 55: 5134 Killed: 9 "$dest" --install --yes
```
The fix is one line in two places: switch from `xattr -d com.apple.quarantine` to `xattr -c` (clear all xattrs).
Why no `codesign`
The Go toolchain already ad-hoc signs the binary at build time, so we don't need to invoke `codesign` ourselves. Avoiding it keeps the install path tooling-free.
Test plan