Upload audio changes - #833
Open
SonAndrea wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for dailp canceled.
|
GracefulLemming
approved these changes
Jul 29, 2026
GracefulLemming
left a comment
GracefulLemming
left a comment
Contributor
There was a problem hiding this comment.
Thank you for these changes @SonAndrea and thank you for explaining why you didn't use the existing upload component. I see that users now do not need to allow their microphone access to upload audio, and I see you updated some of the prompt text for browsers that don't support audio recording.
Based on your comments, it might be helpful if you remove the old upload code so we can cut back on clutter but that can be done in a separate PR. For this PR, we should merge to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the audio component to allow a user to upload audio when the microphone is disabled. Additionally, in the original pr that was merged, @GracefulLemming, asked:
"I also see you are modifying the recording component directly. Is there a reason you avoided the existing upload code held in the same folder?"
I used and modified the existing upload code and put it directly within the audio recording as I find that typically on other sites with similar features, the record and upload are within the same component. With using the current implementation in upload.tsx, there would be two separate sections where users can do both at the same time. I wanted to limit the freedom to simplify it and prevent any complications of a user being able to submit uploaded and recorded audio in different places.