This repository was archived by the owner on Apr 24, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add default url to nodes #346
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
src/test/java/no/ndla/taxonomy/domain/NodeUrlNameTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Part of NDLA taxonomy-api | ||
| * Copyright (C) 2026 NDLA | ||
| * | ||
| * See LICENSE | ||
| */ | ||
|
|
||
| package no.ndla.taxonomy.domain; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| import java.util.Set; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class NodeUrlNameTest { | ||
|
|
||
| @Test | ||
| void translatedPrettyNamesSkipsNullTranslationNames() { | ||
| var node = new Node(NodeType.TOPIC); | ||
| node.setName("Default Name"); | ||
| node.addTranslation(new JsonTranslation(null, "nn")); | ||
|
|
||
| assertEquals(Set.of("default-name"), node.translatedPrettyNames()); | ||
| } | ||
| } |
41 changes: 41 additions & 0 deletions
41
src/test/java/no/ndla/taxonomy/service/dtos/NodeDTOTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* | ||
| * Part of NDLA taxonomy-api | ||
| * Copyright (C) 2026 NDLA | ||
| * | ||
| * See LICENSE | ||
| */ | ||
|
|
||
| package no.ndla.taxonomy.service.dtos; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.springframework.test.util.ReflectionTestUtils.getField; | ||
|
|
||
| import java.util.Optional; | ||
| import no.ndla.taxonomy.domain.Node; | ||
| import no.ndla.taxonomy.domain.NodeConnectionType; | ||
| import no.ndla.taxonomy.domain.NodeType; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class NodeDTOTest { | ||
|
|
||
| @Test | ||
| void defaultUrlNameUsesDefaultLanguageTranslation() { | ||
| var node = new Node(NodeType.TOPIC); | ||
| node.setName("English base name"); | ||
| node.addTranslation("Bokmal default name", "nb"); | ||
|
|
||
| var dto = new NodeDTO( | ||
| Optional.empty(), | ||
| Optional.empty(), | ||
| node, | ||
| NodeConnectionType.BRANCH, | ||
| "en", | ||
| Optional.empty(), | ||
| false, | ||
| false, | ||
| true, | ||
| false); | ||
|
|
||
| assertEquals("bokmal-default-name", getField(dto, "defaultUrlName")); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.