Skip to content

fix: return 400 instead of 500 for invalid numeric IDs#755

Merged
amatho merged 1 commit into
masterfrom
fix/numeric-id-response-status
Jul 3, 2026
Merged

fix: return 400 instead of 500 for invalid numeric IDs#755
amatho merged 1 commit into
masterfrom
fix/numeric-id-response-status

Conversation

@amatho

@amatho amatho commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Fiks for samme problem som NDLANO/ndla-frontend#2958.

Har brukt 404 her, men er det bedre med 400 kanskje?

@amatho amatho requested a review from a team July 2, 2026 07:56

@gunnarvelle gunnarvelle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenker 400 er bedre for det er jo feil i parameter.

@amatho amatho force-pushed the fix/numeric-id-response-status branch from 293fb44 to 211f2e7 Compare July 2, 2026 08:15
@amatho amatho requested a review from gunnarvelle July 2, 2026 08:15
@amatho amatho changed the title fix: return 404 instead of 500 for invalid numeric IDs fix: return 400 instead of 500 for invalid numeric IDs Jul 2, 2026

@gunnarvelle gunnarvelle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenker 400 er bedre for det er jo feil i parameter.

@amatho amatho merged commit 182ca21 into master Jul 3, 2026
3 checks passed
@amatho amatho deleted the fix/numeric-id-response-status branch July 3, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants