Support namespacing controller launches - #5
Merged
Conversation
ndunkelb-nasa
requested changes
Apr 17, 2026
ndunkelb-nasa
left a comment
ndunkelb-nasa
left a comment
Contributor
There was a problem hiding this comment.
Yeah, this looks fairly straightforward. I am wondering - should we monorepo this into CLR? I don't really see a good reason for us to maintain this separately. I don't think we will integrate a vention rail in this exact config elsewhere.
| constraints: | ||
| stopped_velocity_tolerance: 0.2 | ||
| goal_time: 0.0 | ||
| vention_rail_base_to_carriage: { trajectory: 0.1, goal: 0.1 } |
Contributor
There was a problem hiding this comment.
Suggested change
| vention_rail_base_to_carriage: { trajectory: 0.1, goal: 0.1 } | |
| $(var tf_prefix)vention_rail_base_to_carriage: { trajectory: 0.1, goal: 0.1 } |
eholum-nasa
commented
Apr 21, 2026
eholum-nasa
left a comment
eholum-nasa
left a comment
Member
Author
There was a problem hiding this comment.
I am wondering - should we monorepo this into CLR?
The only reason that I hesitate is I think this can be used with not CLR. There are other vention rails in the wild and maybe having this be standalone is more generally helpful?
ndunkelb-nasa
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might as well support this here since it isn't a huge change.