ci(semgrep): consume the fleet-shared reusable Semgrep workflow#1760
Open
krisarmstrong wants to merge 2 commits into
Open
ci(semgrep): consume the fleet-shared reusable Semgrep workflow#1760krisarmstrong wants to merge 2 commits into
krisarmstrong wants to merge 2 commits into
Conversation
Replace seed's byte-identical Semgrep job with a call to MustardSeedNetworks/.github's reusable semgrep.yml (Phase 3). ci-complete still needs: [semgrep]. Verified via niac canary (#1008, CI Complete green).
Pin the license-check + semgrep reusable-workflow refs to MustardSeedNetworks/.github@v1.0.0 (762b756) instead of @main, matching the fleet's action-pinning discipline and the .github README's stated pattern. Renovate bumps these github-actions refs like any other pinned action (same model as the foundation module), so the one-edit-point holds while a bad shared-workflow push is gated by each repo's CI rather than landing instantly fleet-wide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace seed's byte-identical Semgrep job with a call to
MustardSeedNetworks/.github's reusablesemgrep.yml(Phase 3).ci-completestillneeds: [semgrep]; the caller job keeps idsemgrepand its result propagates from the reusable workflow.Verified end-to-end on the niac canary (#1008): reusable Semgrep SAST green + CI Complete green.
Linked Issue
Related to #1751
Testing Evidence
niac #1008 (same reusable workflow): Semgrep SAST pass, CI Complete pass.
Security and Release Checklist