Fix issues with concurrent testing - #995
Open
AHSauge wants to merge 7 commits into
Open
Conversation
This bypasses the need to even write System.lua by feeding it in-memory when we patch it
This prevents test cases failing due to clashing file access
This should finally allow test cases to safely run in parallel
This was referenced Aug 17, 2026
Collaborator
Author
|
As anyone following this PR will have seen, the initial fixes still didn't resolve all the intermittent failures. After a bit more debugging on Windows, I think I've ironed out the remaining issues. The challenge here is that different builds (debug vs release), platforms, concurrency, and timing all play a part in when and how these things get triggered. Both debug and release on Fedora 44 (on HW) in addition to debug on a Windows VM seems to work now, so I'm just going 🤞 and hope this was all. |
devwolf75
added a commit
to devwolf75/Gittyup-Windows
that referenced
this pull request
Aug 25, 2026
Fixes flaky TreeView failures on Windows CI (backport of the relevant part of Murmele#995).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes six issues causing intermittent failure in the test cases
TreeViewtest case is prone to fail. I got Claude to debug this for me, but there seems to be a missing wait-for-refresh in theTreeViewtest code. I've copied some wait code use elsewhere in the test code to wait for aQAbstractItemModelobject to be fully refreshed.I've been running this quite a few times, and
ctest -jN(N for example being 32) no longer seem to fail. Typically, particularly theTreeViewtest case was prone to fail, and we've seen this in the GitHub CI/CD pipeline for Windows. I'm pretty confident this will fix those problem.Added bonus is that the test cases run far faster in parallel, and it has no chance to mess up the user settings if it crashes.
Fixes #546
Fixes #769