Skip to content

Macos windows - #908

Closed
Murmele wants to merge 16 commits into
masterfrom
macos_windows
Closed

Macos windows#908
Murmele wants to merge 16 commits into
masterfrom
macos_windows

Conversation

@Murmele

@Murmele Murmele commented Dec 3, 2025

Copy link
Copy Markdown
Owner

No description provided.

@Murmele
Murmele marked this pull request as ready for review December 3, 2025 12:20
@Murmele
Murmele force-pushed the macos_windows branch 2 times, most recently from cf29504 to e88dba7 Compare December 4, 2025 15:38
@Murmele Murmele mentioned this pull request Dec 31, 2025
Open
@AMDphreak AMDphreak mentioned this pull request Jan 19, 2026
Draft
@AMDphreak

AMDphreak commented Jan 19, 2026

Copy link
Copy Markdown

I've noticed that this PR fixes the missing Windows binaries for v2.0.0. I've submitted a PR (#934) to your branch that fixes the formatting issues in Indexer.cpp which were causing the CI to fail. I hope this helps in getting the Windows/macOS builds back online!

@Murmele

Murmele commented Jan 19, 2026

Copy link
Copy Markdown
Owner Author

I've noticed that this PR fixes the missing Windows binaries for v2.0.0. I've submitted a PR (#934) to your branch that fixes the formatting issues in Indexer.cpp which were causing the CI to fail. I hope this helps in getting the Windows/macOS builds back online!

Unluckily it will not. The problem is that there is a linker error for libssh2 both in macos and windows (Maybe the same).

@Murmele Murmele mentioned this pull request Feb 3, 2026
Open
@Murmele

Murmele commented Mar 14, 2026

Copy link
Copy Markdown
Owner Author

When checking the install output for macos and windows the library will be installed. It is just missing in the bundle

@Murmele

Murmele commented Apr 5, 2026

Copy link
Copy Markdown
Owner Author

Closed in favour of #949

@Murmele Murmele closed this Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Murmele @AMDphreak @TaliesinToo @BrendenWalker