Skip to content

14 include all modern matlab versions in automated testing#47

Open
dmitrisvetlov wants to merge 15 commits into
mainfrom
14-include-all-modern-matlab-versions-in-automated-testing
Open

14 include all modern matlab versions in automated testing#47
dmitrisvetlov wants to merge 15 commits into
mainfrom
14-include-all-modern-matlab-versions-in-automated-testing

Conversation

@dmitrisvetlov

Copy link
Copy Markdown
Collaborator

This updates the automated SSIT testing as follows:

  1. Windows is included as an OS along with Linux.
  2. The dependency on the Image Processing Toolbox is removed.
  3. Because of the above, the earliest supported version is now R2023b, which is when the paddata function was introduced to core MATLAB.

Most tests pass on all platforms. The earlier versions (R2023b and R2024a) have three errors due to

Error using matlab.internal.decomposition.builtin.luSolve
      Decomposition built-in error: 3rd input (B) must be a dense matrix of
      matching
      size and same datatype as A.
      
      Error in odesolve (line 9)
          x = matlab.internal.decomposition.builtin.luSolve(Factors,piv,b);
      
      Error in ode23s (line 337)
              k1 = odesolve(Factors, piv, k1aux);
      
      Error in SSIT/solveHelper (line 2303)
                          [~,soln] =
                          odeIntegrat(RHS,obj.tSpan,initMeans,options);
      
      Error in SSIT/solve (line 1986)
                      [Solution, bConstraints, obj] =
                      obj.solveHelper(stateSpace,saveFile,fspSoln);

The latest version (R2026a?) has only one error, due to a simple typo.

Error occurred in poissonTest/PoissonMoments and it did not run to completion.
      ---------
      Error ID:
      ---------
      'MATLAB:nonExistentField'
      --------------
      Error Details:
      --------------
      Unrecognized field name "momenstsCOV".
      
      Error in poissonTest/PoissonMoments (line 147)
                  var2 = squeeze(model.Solutions.momenstsCOV(1,1,:))';

Given the typo, I am not sure how that tests passes on main, but apparently it does...I will make an issue to fix it.

If the solution-related errors are artifacts of R2023b and R2024a and cannot be easily fixed, we can stop supporting those versions and try to find the earliest later version that does work. But perhaps there is a fix.

Either way, I think we can reintegrate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include all modern MATLAB versions in automated testing

2 participants