Skip to content

changed preflight check of logfiles to also include multiple logfiles… - #145

Merged
cbueth merged 4 commits into
mainfrom
feat/preflight_multiple_logfiles
Jul 28, 2026
Merged

changed preflight check of logfiles to also include multiple logfiles…#145
cbueth merged 4 commits into
mainfrom
feat/preflight_multiple_logfiles

Conversation

@saphjra

@saphjra saphjra commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

…, not only no logfiles as described in #144

@saphjra
saphjra requested a review from cbueth July 17, 2026 14:13
@cbueth
cbueth self-requested a review July 17, 2026 14:40
cbueth
cbueth requested changes Jul 17, 2026
View reviewed changes

@cbueth cbueth left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing preflight tests need to be changed.

@theDebbister theDebbister mentioned this pull request Jul 28, 2026
Merged
@cbueth
test: fix tests for DATA_LOGFILE and strict logfile count checks
5b67563 
Signed-off-by: Carlson Büth <commit@cbueth.de>
cbueth
cbueth reviewed Jul 28, 2026
View reviewed changes

@cbueth cbueth left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests did not account for the new DATA_LOGFILE_*.txt check added in the preflight logic, nor for the != 1 semantics that replace the old == 0 checks. I added the missing logfile to all test fixtures, added a data_logfile_missing test scenario, and fixed an unrelated naming inconsistency in test_preflight_stimulus_dir_empty_with_archive. See 5b67563.

Comment thread preprocessing/checks/preflight.py
@cbueth
feat: add DATA_LOGFILE check and descriptive messages for duplicate…
408a64f 
… logfiles

Signed-off-by: Carlson Büth <commit@cbueth.de>
@cbueth

cbueth commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

The previous != 1 check included missing and duplicate logfiles into one generic error group. I changed that each logfile type (EXPERIMENT, DATA_LOGFILE, GENERAL_LOGFILE) distinguishes between "missing" and "too many files" with a dedicated "Multiple *.txt logfiles" error group that includes the session ID and file count. This also added the DATA_LOGFILE_*.txt check that was missing from the original commit, and updated test fixtures and scenarios to cover both missing and duplicate cases.

@cbueth
Merge remote-tracking branch 'origin/main' into feat/preflight_multip…
b4ea9a2 
…le_logfiles

# Conflicts:
#	preprocessing/checks/preflight.py
@cbueth
cbueth merged commit 7d3e6cb into main Jul 28, 2026
2 checks passed
@cbueth
cbueth deleted the feat/preflight_multiple_logfiles branch July 28, 2026 13:56
@saphjra saphjra mentioned this pull request Jul 29, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbueth cbueth cbueth requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saphjra @cbueth