Skip to content

feat(notifications): add push notifications for completed and no-show… - #174

Merged
MukhammadIbrokhimov merged 3 commits into
mainfrom
feature/android-fcm-push-notifications
Mar 18, 2026
Merged

feat(notifications): add push notifications for completed and no-show…#174
MukhammadIbrokhimov merged 3 commits into
mainfrom
feature/android-fcm-push-notifications

Conversation

@MukhammadIbrokhimov

Copy link
Copy Markdown
Owner

… bookings

  • booking_completed: prompts user to leave a review after visit
  • booking_no_show: friendly message when guest misses reservation
  • All messages in en/uz/ru

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation update
  • Infrastructure/DevOps change
  • Other (please describe):

Changes Made

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Evidence

# Commands run for testing

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

… bookings

- booking_completed: prompts user to leave a review after visit
- booking_no_show: friendly message when guest misses reservation
- All messages in en/uz/ru
Copilot AI review requested due to automatic review settings March 18, 2026 02:22
- Add icon='ic_notification' to AndroidNotification
- Add color='#B52428' (brand red) for notification accent

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the booking status → push-notification mapping so users can receive push notifications when a booking is marked COMPLETED or NO_SHOW, and adds localized notification copy for those new notification types.

Changes:

  • Map Booking.Status.COMPLETED and Booking.Status.NO_SHOW to new notification types in the booking post-save signal.
  • Add booking_completed and booking_no_show localized templates (en/uz/ru) to the notification message catalog.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
backend/apps/notifications/signals.py Adds COMPLETED/NO_SHOW to STATUS_NOTIFICATION_MAP so status changes dispatch new notification types.
backend/apps/notifications/messages.py Adds localized NotificationContent for booking_completed and booking_no_show.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +16 to +17
Booking.Status.COMPLETED: "booking_completed",
Booking.Status.NO_SHOW: "booking_no_show",
Booking.Status.CONFIRMED: "booking_confirmed",
Booking.Status.REJECTED: "booking_rejected",
Booking.Status.CANCELLED: "booking_cancelled",
Booking.Status.COMPLETED: "booking_completed",
Comment on lines +72 to +80
body="How was your experience at {restaurant_name}? We'd love to hear your feedback!",
),
"uz": NotificationContent(
title="Tashrifingiz uchun rahmat! 🍽️",
body="{restaurant_name}da qanday bo'ldi? Fikringizni bilishni xohlaymiz!",
),
"ru": NotificationContent(
title="Спасибо за визит! 🍽️",
body="Как вам в {restaurant_name}? Поделитесь впечатлениями!",
Users authenticating via OTP flow (first-time booking) weren't receiving
push notifications because FCM token wasn't registered after OTP verification.
Now registers token in verifyOtp() same as in login().
@MukhammadIbrokhimov
MukhammadIbrokhimov merged commit a300750 into main Mar 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants