bd-ko1 Part B: detail-page enrichment for min_contract_months - #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enrichpipeline stage between scrape and match. Fetches detail pages for canonical WG-Gesucht / Kleinanzeigen flats missingmin_contract_months, parses the field, and persists it sofilter_contract(filters.py:120-128) actually fires.flats.available_until(forward-migration column) and extendsfilter_short_termto use the structuredavailable_from/available_untilspan before falling back to the bd-33h title/description heuristic.--budget(default 30) and sleeps 2 s between requests. Fetch failures are logged and the flat row is left untouched so the cheap keyword filter remains the safety net.Test plan
pytest tests/test_matcher_filters.py tests/test_pipeline_enrich.py tests/test_wg_gesucht_scraper.py tests/test_kleinanzeigen_scraper.py -v— greenpytest -q— full suite green (589 passed)ruff checkon touched files — no errorsflatpilot enrich --budget 3against a real DB with at least one new WG-Gesucht flat; verify the row'smin_contract_monthsis populated.Closes FlatPilot-k1v.