Add native Speech Dispatcher support - #14
Open
stormdragon2976 wants to merge 3 commits into
Open
Conversation
Suppress non-prosodic symbols retained by server-side symbol preprocessing when Speech Dispatcher selects punctuation mode none. Preserve sentence pauses, intra-word apostrophes, and direct character review, and add regression coverage for duplicated punctuation names.
Author
|
Sorry for the multiple updates—we found a couple of edge cases during real-world screen-reader testing. This amendment fixes duplicated punctuation names caused by Speech Dispatcher retaining symbols for prosody, while preserving direct character review and apostrophes inside words. The updated module has now been tested successfully with both Fenrir and Cthulhu. |
Owner
|
This is awesome, I only just saw this PR. I currently use Eloquence on Linux but I've been meaning to switch to OpenEVV my self and make an SPD module so I appreciate you handling this. I'll take a look at this in a minute, there's been a number of changes done that need to be resolved since this PR was made before I merge it, but I'll take care of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Punctuation and symbol expansion deliberately remain in Speech Dispatcher's language-aware server preprocessing. The regression suite checks that normalized plain module text is byte-for-byte equivalent to direct OpenEVV synthesis so Unicode punctuation and module control sequences cannot become incorrectly spoken text.
Verification
make -j4 RULES=bytecode speechd-test-allmake -j4 RULES=c speechd-test-alltest/hash.sh build/evvspeechd/openevv.ctest/speechd.pyspd-say -o openevv "this is a test"playback confirmed without spoken control codesAudible punctuation-mode differences and broader screen-reader interruption/latency behavior remain manual acceptance checks because the direct protocol test bypasses the Speech Dispatcher server's symbol preprocessor and audio backend.