Add better parsing of email addresses and add tests for mailgun#407
Open
duckduckgrayduck wants to merge 1 commit into
Open
Add better parsing of email addresses and add tests for mailgun#407duckduckgrayduck wants to merge 1 commit into
duckduckgrayduck wants to merge 1 commit into
Conversation
duckduckgrayduck
force-pushed
the
fix_mailkey_uuid_parsing
branch
from
e2aa7c1 to
7246911
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our previous logic took everything before the first @, which in some cases would include a leading quotation mark " (depending I guess on the email server sending it) like:
""uuid@uploads.documentcloud.org" uuid@uploads.documentcloud.org"
in the To field. This PR moves us to use a more robust and built in email parsing email.utils.parseaddr which will handle those leading quotes automatically, as well as < and other possible symbols. It also automatically rejects malformed inputs for safety.
This PR also raises ValidationErrors in case parseaddr somehow doesn't catch anything and adds some tests for mailgun since there were none. I had Claude write the tests because they are boilerplate.
Closes #406