ci: bump GitHub Actions to Node 24 native versions - #13
Merged
Conversation
GitHub is deprecating Node 20 on Actions runners, so actions pinned to Node-20 majors were being force-run on Node 24 with a warning. Bump each to its latest major that natively targets Node 24 (runs.using: node24): - actions/checkout v4 -> v7 - actions/setup-python v5 -> v6 - actions/upload-artifact v4 -> v7 - actions/download-artifact v4 -> v8 upload v7 and download v8 both use the @actions/artifact v6 backend, so they stay compatible. pypa/gh-action-pypi-publish@release/v1 is a Docker action (no Node runtime) and emits no warning, so it is left unchanged. CI config only: no package version bump, no PyPI release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The CI 3.9 matrix leg was failing at the mypy step (and thus red on main), which blocked pytest from ever running on 3.9: - core.py used PEP 604 `X | Y` union syntax in annotations, which mypy rejects for a 3.9 target and which raises TypeError at import time on 3.9. Add `from __future__ import annotations` (matches the other modules in the package) so the annotations are lazy and valid on 3.9. - rules.py passed a compiled `re.Pattern` to `Series.str.fullmatch`, whose stub expects `str`. The pattern is already validated at rule-load time and pandas compiles internally, so pass the pattern string directly and drop the redundant `re.compile` call. Behavior unchanged. Verified: ruff clean, mypy clean, 233 tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the GitHub Actions in both workflow files to the latest majors that natively run on Node 24, clearing the Node 20 deprecation warning.
runs.usingFiles touched:
.github/workflows/ci.yml,.github/workflows/publish.yml.Notes
runs.using: node24value on each new major was verified against the action'saction.ymlat its latest release tag.v7and download-artifactv8both depend on the@actions/artifactv6 backend, so they interoperate — the v4-upload-requires-v4-download constraint is satisfied by keeping both on post-v4 majors.pypa/gh-action-pypi-publish@release/v1is a Docker-based action with no Node runtime, so it emits no Node 20 warning and is left as-is.Scope
CI config only — no package version bump, no PyPI release, no tag.
🤖 Generated with Claude Code