Repository navigation
Fix scrolling capture stopping at the first page and release 1.9.1 - #133
Merged
Merged
Conversation
Finishing a scrolling capture before the last small scroll settled dropped that final viewport, so a capture could return only the first page. Done now drains the in-flight step and the final movement, and an uncertain join pauses for review instead of returning a truncated image. Scrolling capture now scrolls automatically by default in small overlapping steps (20% of the content height, 0.25s settle, 200 steps / 2 minutes, paused after 3 unchanged steps). It posts events to the original window only after the user grants Accessibility. A new Preferences > Capture option turns it off for manual scrolling, which shows a too fast, too slow or steady pace indicator. Updates the README, guide, CORE_API and CONTRIBUTING checklist and prepares the 1.9.1 release. Fixes #132 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scrolling capture could return only the first viewport: pressing Done right after a small scroll, before the page settled, dropped that last viewport. Capture also relied on the user scrolling at a pace the engine could follow, with no feedback.
glint.scrollCaptureAutoScroll, default on, restored by Reset). Turning it off scrolls manually without requesting the extra permission and shows a pace indicator: Too fast — slow down to keep frames aligned., Steady — keep this pace., Too slow — scroll down a little, or choose Done if finished.docs/CORE_API.md, the CONTRIBUTING manual checklist and the changelog are updated, and the version is bumped to 1.9.1 withmake prepare-release VERSION=1.9.1.Issue
Fixes #132
Verification
Scripts/swiftw.sh test --no-parallel— passed: Test run with 1504 tests in 137 suites.Scripts/swiftw.sh test --no-parallel --filter 'ScrollCapture|ScrollStitcher|ScrollGrabPolicy|ExportAndPrefsTests/(scrollingCaptureDefaultsToAutomaticAndPersistsManualMode|resetRestoresAutomaticScrollingCapture)|ScrollingCapturePipelineTests'— passed: 52 tests in 8 suites, including the new regressionfinishingCapturesTheFinalSmallScrollBeforeItSettles, Done during a delayed scroll, manual pace, target loss, denied permission, source failure, safety limit, unsettled/bad join and undo cases (all against fake scroll sources).make prepare-release VERSION=1.9.1,node .github/scripts/changelog.cjs checkandnode --test .github/scripts/site.test.cjs .github/scripts/changelog.test.cjs— passed (32 tests).make app— builtdist/Glint.app1.9.1 (92), ad-hoc signed locally; the release workflow produces the Developer ID signed and notarized artifacts from the tag.git diff --check— clean.Manual gap: real desktop scrolling (event delivery to a live window, the Accessibility prompt and the on-screen HUD colors) was not exercised in this environment; the scroll driver and permission paths are covered by fakes only. The CONTRIBUTING manual checklist covers it.