Skip to content

fix(tests): guard OpenAI embedding tests and drop read-only property monkeypatch (#288) #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mr-DooSun merged 1 commit into from
Jul 14, 2026
+7 −2
Merged

fix(tests): guard OpenAI embedding tests and drop read-only property monkeypatch (#288) #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/integration/classification/test_classification_stub_fallback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ def llm_disabled(self, monkeypatch: pytest.MonkeyPatch) -> None:
"""Force the LLM selector into its ``disabled`` branch."""
monkeypatch.setattr(settings, "llm_provider", None)
monkeypatch.setattr(settings, "llm_model", None)
monkeypatch.setattr(settings, "llm_model_name", None)

@pytest.mark.asyncio
async def test_stub_classifier_produces_dto(self):
Expand Down
8 changes: 7 additions & 1 deletion tests/unit/_core/infrastructure/embedding/test_pydantic_ai_embedding_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
from src._core.domain.value_objects.embedding_config import EmbeddingConfig

_has_pydantic_ai = importlib.util.find_spec("pydantic_ai") is not None
_has_openai_embeddings = (
importlib.util.find_spec("pydantic_ai") is not None
and importlib.util.find_spec("openai") is not None
)


class TestEmbeddingConfigValueObject:
Expand Down Expand Up @@ -156,7 +160,9 @@ async def test_error_mapping_generic(self):
await adapter.embed_text("test")


@pytest.mark.skipif(not _has_pydantic_ai, reason="pydantic-ai not installed")
@pytest.mark.skipif(
not _has_openai_embeddings, reason="pydantic-ai + openai not installed"
)
class TestOpenAIBatchSplitting:
"""OpenAI 프로바이더의 배치 분할 로직 테스트."""

Expand Down
Loading