Repository navigation
Name each test build's download after the file in it - #45
Merged
Merged
Conversation
A run's downloads were called rpm-x86_64, deb-arm64, appimage-aarch64, arch and aur, which said neither the file nor who it is for, so picking the right one was guesswork. Each is now a zip named after the one file in it, the name it has on a release page (weir_1.4.0_amd64.deb, Weir-1.4.0-x86_64.AppImage), and the run's summary has a table of which is for which system. An AppImage and its .zsync file are now two downloads, and the AUR recipe is aur-recipe. The release job takes the files by type now, so it runs on every build to gather and count them and write the checksums, and only a release signs and attaches them. A mistake there would otherwise first show in a release, which then has to be published again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PWaMWDrXpfpALWtEnsyueZ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PWaMWDrXpfpALWtEnsyueZ
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #43 (which is on #42). Merge those first, then change this one's base to
main. It's on its own branch so #43's builds, which are being tested, are left alone.Why
A Packages run's downloads were called
rpm-x86_64,deb-arm64,appimage-aarch64,archandaur. Those names said neither which file is inside nor who it's for, so picking the right one was guesswork.What changes
Each download is a zip named after the one file in it, with the same name the file has on a release page:
weir-1.4.0-1.fc44.x86_64.rpmweir_1.4.0_amd64.debWeir-1.4.0-x86_64.AppImageweir-1.4.0-1-x86_64.pkg.tar.zstThey stay zipped, as before.
A table on the run's summary page says which download is for which system, and that x86_64/amd64 means an ordinary Intel or AMD computer. It also says the
.zsyncfiles andaur-recipearen't for installing.An AppImage and its
.zsyncfile are now two downloads, so each zip holds only what its name says.auris nowaur-recipe.The release job now runs on every build. It takes the files by type (
*.{rpm,deb,AppImage,zsync,zst}), so it now:.zsyncfiles and one Arch package;Only a release signs and attaches the files. Before, a mistake here would first show up during a release, which then has to be deleted and published again.
CONTRIBUTING says the same.
Release pages are unchanged: they already list the files under their full names.
Tested
actionlintpasses on the workflow.download-artifactuses: every package matches, andaur-recipedoesn't.Generated by Claude Code