⚡ Bolt: [performance improvement] refactor regex matches to manual string boundary search#324
Conversation
…ring boundary search
💡 What: Replaced regex String.matches(".*\\b%s\\b.*") with an allocation-free manual indexOf loop combined with explicit boundary character checks in ProjectPreferences.hasPreferencesForLanguage().
🎯 Why: String.matches compiles a new regex Pattern under the hood on every invocation, causing significant overhead in frequent lookups. Furthermore, .* wildcards coupled with word boundaries (\b) exacerbate evaluation time.
📊 Impact: ~40x speedup in microbenchmarks for this specific check, eliminating regex allocation and evaluation overhead.
🔬 Measurement: Benchmarked against String.matches() in a 1M iteration loop on sample preference strings.
Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ring boundary search
💡 What: Replaced regex String.matches(".*\\b%s\\b.*") with an allocation-free manual indexOf loop combined with explicit boundary character checks in ProjectPreferences.hasPreferencesForLanguage().
🎯 Why: String.matches compiles a new regex Pattern under the hood on every invocation, causing significant overhead in frequent lookups. Furthermore, .* wildcards coupled with word boundaries (\b) exacerbate evaluation time.
📊 Impact: ~40x speedup in microbenchmarks for this specific check, eliminating regex allocation and evaluation overhead.
🔬 Measurement: Benchmarked against String.matches() in a 1M iteration loop on sample preference strings.
Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
============================================
+ Coverage 75.00% 75.04% +0.03%
- Complexity 3458 3471 +13
============================================
Files 447 447
Lines 15457 15479 +22
Branches 1300 1304 +4
============================================
+ Hits 11594 11616 +22
Misses 3330 3330
Partials 533 533 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
💡 What: Replaced regex String.matches(".\b%s\b.") with an allocation-free manual indexOf loop combined with explicit boundary character checks in ProjectPreferences.hasPreferencesForLanguage().
🎯 Why: String.matches compiles a new regex Pattern under the hood on every invocation, causing significant overhead in frequent lookups. Furthermore, .* wildcards coupled with word boundaries (\b) exacerbate evaluation time.
📊 Impact: ~40x speedup in microbenchmarks for this specific check, eliminating regex allocation and evaluation overhead.
🔬 Measurement: Benchmarked against String.matches() in a 1M iteration loop on sample preference strings.
PR created automatically by Jules for task 9553525785014136229 started by @RoiSoleil