-
Notifications
You must be signed in to change notification settings - Fork 1
Clarify ENS preview vs effective semantics in docs and UI (no manager bytecode changes) #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2971,10 +2971,10 @@ <h2 style="margin:0 0 12px">2) Create a Job (Employer)</h2> | |
| <tr><td>Job label prefix</td><td><span id="ensJobLabelPrefixPreview">—</span></td></tr> | ||
| <tr><td>Next job id</td><td><span id="ensNextJobId">—</span></td></tr> | ||
| <tr><td>Snapshot status</td><td><span id="ensSnapshotStatus">—</span></td></tr> | ||
| <tr><td>Effective label</td><td><span id="predictedJobLabel">—</span></td></tr> | ||
| <tr><td>Effective ENS name</td><td><span id="predictedEnsName">—</span></td></tr> | ||
| <tr><td>Effective ENS URI</td><td><span id="predictedEnsURI">—</span></td></tr> | ||
| <tr><td>Effective node</td><td><span id="predictedEnsNode">—</span></td></tr> | ||
| <tr><td>Preview label</td><td><span id="predictedJobLabel">—</span></td></tr> | ||
| <tr><td>Preview ENS name</td><td><span id="predictedEnsName">—</span></td></tr> | ||
| <tr><td>Preview ENS URI</td><td><span id="predictedEnsURI">—</span></td></tr> | ||
| <tr><td>Preview node</td><td><span id="predictedEnsNode">—</span></td></tr> | ||
| <tr><td>ENSJobPages useEnsJobTokenURI</td><td><span id="ensTokenUriMode">—</span></td></tr> | ||
| <tr><td>AGIJobManager tokenURI mode</td><td><span id="managerTokenUriMode">owner-configurable, getter unavailable</span></td></tr> | ||
| <tr><td>Config locked</td><td><span id="ensConfigLocked">—</span></td></tr> | ||
|
|
@@ -5468,7 +5468,7 @@ <h2 style="margin:0 0 10px">Contact & Legal</h2> | |
| function useEnsUriPreview(){ | ||
| const uri = (el("predictedEnsURI")?.textContent || "").trim(); | ||
| if(!uri || uri === "—"){ setToast("No ENS URI preview available.", "warn"); return; } | ||
| navigator.clipboard.writeText(uri).then(()=>setToast("Effective ENS URI copied.", "ok")).catch(()=>setToast(uri, "ok")); | ||
| navigator.clipboard.writeText(uri).then(()=>setToast("ENS URI copied (preview or authoritative depending on snapshot status).", "ok")).catch(()=>setToast(uri, "ok")); | ||
| } | ||
| async function updateEnsJobPagePreview(){ | ||
| try{ | ||
|
|
@@ -7677,7 +7677,7 @@ <h2 style="margin:0 0 10px">Contact & Legal</h2> | |
| body:'You are about to call the public ENS lock path for a terminal job. This is best-effort and depends on the ENSJobPages configuration and terminal state.', | ||
| facts:[ | ||
| {label:'Job status', value: job ? classifyJobStatus(job) : 'Unknown'}, | ||
| {label:'Effective ENS name', value: currentLivePacket?.job?.id === jobId ? (currentLivePacket.job.ensName || '—') : (job ? ensLabelPreviewForJobId(jobId) : '—')}, | ||
| {label:'Preview ENS name', value: currentLivePacket?.job?.id === jobId ? (currentLivePacket.job.ensName || '—') : (job ? ensLabelPreviewForJobId(jobId) : '—')}, | ||
| {label:'Burn fuses', value: 'false'}, | ||
| {label:'Terminal requirement', value: 'Completed or expired only'} | ||
| ], | ||
|
|
@@ -8340,8 +8340,8 @@ <h2 style="margin:0 0 10px">Contact & Legal</h2> | |
| el('jobUriCards').innerHTML = [ | ||
| ['Spec URI', safeLink(job.specURI)], | ||
| ['Completion URI', job.completionURI ? safeLink(job.completionURI) : '—'], | ||
| ['Effective ENS URI', ens.ensUri ? safeLink(ens.ensUri) : '—'], | ||
| ['Effective ENS name', escapeHtml(ens.ensName || '—')] | ||
| ['ENS URI (preview or authoritative, see snapshot status)', ens.ensUri ? safeLink(ens.ensUri) : '—'], | ||
| ['ENS name (preview or authoritative, see snapshot status)', escapeHtml(ens.ensName || '—')] | ||
|
Comment on lines
+8343
to
+8344
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
These labels now tell the reader to "see snapshot status", but the job-detail modal does not render any snapshot indicator and Useful? React with 👍 / 👎. |
||
| ].map(([k,v])=>`<div class="ensRecord"><div class="k">${k}</div><div class="v">${v}</div></div>`).join(''); | ||
| el('jobEnsRecords').innerHTML = [ | ||
| ['ENS root', escapeHtml(ens.rootName || '—')], | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For terminal jobs, this dialog usually shows
currentLivePacket.job.ensName, which comes fromfetchEnsVisibility()viaENSJobPages.jobEnsName(). In the checked contract path (contracts/ens/ENSJobPages.sol::_createJobPage), authority is established at create time, so completed/expired jobs normally have an effective name already. Relabeling that field to "Preview ENS name" reintroduces the exact ambiguity this patch is trying to remove right before the operator signslockJobENS(...).Useful? React with 👍 / 👎.