Library/Layout: Implement LayoutUtil - #833
Merged
MonsterDruide1 merged 2 commits intoDec 24, 2025
Merged
Conversation
github-actions
Bot
added
the
status:waiting for review
Contributor
|
You can implement the missing objects in other projects like https://github.com/open-ead/eui and https://github.com/open-ead/nnheaders. There's also a good chance that someone already RE those objects for another game like botw and they just need to be added to the repo but unless is from a trusted source please double check the info. |
Contributor
Author
|
There is a draft PR for nn::ui2d::DrawInfo on nnheaders open-ead/nnheaders/pull/25, but I don't think I understand assembly/reverse engineering c++ enough to figure out what members structs/classes are made of |
MonsterDruide1
changed the title
LayoutUtil
MonsterDruide1
approved these changes
Dec 23, 2025
MonsterDruide1
left a comment
MonsterDruide1
left a comment
Owner
There was a problem hiding this comment.
@MonsterDruide1 reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MissBismuth).
github-actions
Bot
added
status:approved
codeman4033
pushed a commit
to CodemanSMODecomp/OdysseyDecomp
that referenced
this pull request
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't add:
setRenderBuffer(al::setRenderBuffer(al::LayoutKit*, agl::RenderBuffer const*)) as it requires nn::ui2d::DrawInfo size
al::executeUpdate(al::LayoutKit*) as it requires eui::ScreenMgr
This change is
Report for 1.0 (f0237ea - 91e84c0)
📈 Matched code: 9.97% (+0.00%, +144 bytes)
✅ 5 new matches
Library/Layout/LayoutUtilal::initLayoutInitInfo(al::LayoutInitInfo*, al::LayoutKit const*, al::SceneObjHolder*, al::AudioDirector const*, al::LayoutSystem const*, al::MessageSystem const*, al::GamePadSystem const*)Library/Layout/LayoutUtilal::executeDrawEffect(al::LayoutKit const*)Library/Layout/LayoutUtilal::executeUpdateList(al::LayoutKit*, char const*, char const*)Library/Layout/LayoutUtilal::executeUpdateEffect(al::LayoutKit*)Library/Layout/LayoutUtilal::executeDraw(al::LayoutKit const*, char const*)