Skip to content

Library/Camera: Partially Implemented CameraPoserFunction - #806

Open
Muz-dev wants to merge 7 commits into
MonsterDruide1:masterfrom
Muz-dev:CameraPoserFunction
Open

Library/Camera: Partially Implemented CameraPoserFunction#806
Muz-dev wants to merge 7 commits into
MonsterDruide1:masterfrom
Muz-dev:CameraPoserFunction

Conversation

@Muz-dev

@Muz-dev Muz-dev commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

I was working on this class for a bit but I don't want to endlessly implement small function.
Also idk whats happening with the other stuff, can somebody explain what is going on?


This change is Reviewable


Report for 1.0 (806645f - 7b88633)

📈 Matched code: 14.79% (+0.05%, +6084 bytes)

✅ 105 new matches
Unit Item Bytes Before After
Library/Camera/CameraPoserFunction alCameraPoserFunction::checkValidTurnToSubTarget(al::CameraPoser const*) +504 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::tryCalcSubTargetTurnBrakeDistanceRate(float*, al::CameraPoser const*) +296 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcTargetJumpSpeed(al::CameraPoser const*) +248 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcTargetFallSpeed(al::CameraPoser const*) +248 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcTargetSpeedV(al::CameraPoser const*) +232 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcTargetSpeedH(al::CameraPoser const*) +184 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcPreCameraAngleV(al::CameraPoser const*) +176 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcSideDir(sead::Vector3<float>*, al::CameraPoser const*) +152 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcTargetVelocityH(sead::Vector3<float>*, al::CameraPoser const*) +152 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcCameraPose(sead::Quat<float>*, al::CameraPoser const*) +148 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcTargetPose(sead::Quat<float>*, al::CameraPoser const*) +144 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcPreCameraAngleH(al::CameraPoser const*) +136 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcTargetTransWithOffset(sead::Vector3<float>*, al::CameraPoser const*) +132 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcLookDirH(sead::Vector3<float>*, al::CameraPoser const*) +128 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::setLookAtPosToTargetAddOffset(al::CameraPoser*, sead::Vector3<float> const&) +120 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::setCameraPosToTargetAddOffset(al::CameraPoser*, sead::Vector3<float> const&) +120 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcPreLookDir(sead::Vector3<float>*, al::CameraPoser const*) +116 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcLookDir(sead::Vector3<float>*, al::CameraPoser const*) +108 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::tryGetTargetRequestDistance(float*, al::CameraPoser const*) +108 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcPreCameraDirH(sead::Vector3<float>*, al::CameraPoser const*) +104 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcCameraDirH(sead::Vector3<float>*, al::CameraPoser const*) +92 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcPreLookDirH(sead::Vector3<float>*, al::CameraPoser const*) +92 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::setLookAtPosToTarget(al::CameraPoser*) +92 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::setCameraPosToTarget(al::CameraPoser*) +92 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcSubTargetBack(sead::Vector3<float>*, al::CameraPoser const*) +84 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::clampAngleSubTargetTurnRangeV(float*, al::CameraPoser const*) +84 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::initCameraArrowColliderWithoutThroughPassCollision(al::CameraPoser*) +84 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::initCameraArrowCollider(al::CameraPoser*) +76 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcTargetTrans(sead::Vector3<float>*, al::CameraPoser const*) +64 0.00% 100.00%
Library/Camera/CameraPoserFunction alCameraPoserFunction::calcTargetVelocity(sead::Vector3<float>*, al::CameraPoser const*) +64 0.00% 100.00%

...and 75 more new matches

@github-actions github-actions Bot added the status:waiting for review This PR is ready to take the first or another look at it! label Nov 16, 2025
@MonsterDruide1

Copy link
Copy Markdown
Owner

Please rebase your PR, and make sure that the gitignore is applied properly.

@MonsterDruide1 MonsterDruide1 added status:waiting for author Reviews have shown that the author of this PR needs to change some things. and removed status:waiting for review This PR is ready to take the first or another look at it! labels Nov 21, 2025
@Muz-dev
Muz-dev force-pushed the CameraPoserFunction branch from baa8d09 to 9e23e6e Compare May 8, 2026 19:54
@GRAnimated

Copy link
Copy Markdown
Collaborator

Superseded by #1303. Should this PR be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:waiting for author Reviews have shown that the author of this PR needs to change some things.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants