Skip to content

Library/Model: Implement SkyParam - #1336

Open
german77 wants to merge 1 commit into
MonsterDruide1:masterfrom
german77:SkyParam
Open

Library/Model: Implement SkyParam#1336
german77 wants to merge 1 commit into
MonsterDruide1:masterfrom
german77:SkyParam

Conversation

@german77

@german77 german77 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

A bunch of free symbols. But sadly I couldn't fix ParameterXXX ctor for this class.


This change is Reviewable


Report for 1.0 (b64cbfb - 697ead4)

📈 Matched code: 15.51% (+0.01%, +1288 bytes)

✅ 25 new matches
Unit Item Bytes Before After
Library/Fluid/RippleCtrl al::Parameter<sead::FixedSafeString<64> >::Parameter(sead::FixedSafeString<64> const&, sead::SafeStringBase<char> const&, sead::SafeStringBase<char> const&, sead::SafeStringBase<char> const&, al::ParameterObj*, bool) +516 0.00% 100.00%
Library/Model/SkyDirector al::SkyParam::isEqual(al::IUseRequestParam const&) const +188 0.00% 100.00%
Project/Base/ParamRequestInterp al::IUseRequestParam::copyInterp(al::IUseRequestParam const&, al::IUseRequestParam const&, float) +164 0.00% 100.00%
Project/Base/ParamRequestInterp al::IUseRequestParam::isEqual(al::IUseRequestParam const&) const +104 0.00% 100.00%
Project/Base/ParamRequestInterp al::IUseRequestParam::copy(al::IUseRequestParam const&) +104 0.00% 100.00%
Library/Model/SkyDirector al::SkyParam::getSkyName() const +48 0.00% 100.00%
Library/Model/SkyDirector al::SkyParam::getRotate() const +12 0.00% 100.00%
Library/Model/SkyDirector al::SkyParam::getStarIntensity() const +12 0.00% 100.00%
Library/Model/SkyDirector al::SkyParam::getParamName() const +12 0.00% 100.00%
Library/Fluid/RippleCtrl al::ParameterV3f::getParamTypeStr() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::ParameterV3f::getParamType() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::Parameter<sead::Vector3<float> >::ptr() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::Parameter<sead::Vector3<float> >::ptr() +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::Parameter<sead::Vector3<float> >::size() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::Parameter<sead::Vector3<float> >::getParamTypeStr() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::Parameter<sead::Vector3<float> >::getParamType() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::ParameterString64::getParamTypeStr() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::ParameterString64::getParamType() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::Parameter<sead::FixedSafeString<64> >::ptr() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::Parameter<sead::FixedSafeString<64> >::ptr() +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::Parameter<sead::FixedSafeString<64> >::size() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::Parameter<sead::FixedSafeString<64> >::getParamTypeStr() const +8 0.00% 100.00%
Library/Fluid/RippleCtrl al::Parameter<sead::FixedSafeString<64> >::getParamType() const +8 0.00% 100.00%
Library/Model/SkyDirector al::SkyParam::getParamObj() +8 0.00% 100.00%
Library/Model/SkyDirector al::SkyParam::getParamObj() const +8 0.00% 100.00%
📈 1 improvement in an unmatched item
Unit Item Bytes Before After
Library/Model/SkyDirector al::SkyParam::SkyParam() +184 0.00% 25.00%

@github-actions github-actions Bot added the status:waiting for review This PR is ready to take the first or another look at it! label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:waiting for review This PR is ready to take the first or another look at it!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant