Player: Implement YoshiEgg - #1334
Open
GRAnimated wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
status:waiting for review
german77
reviewed
Aug 11, 2026
german77
left a comment
german77
left a comment
Contributor
There was a problem hiding this comment.
@german77 made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on GRAnimated).
src/Player/YoshiEgg.cpp line 107 at r1 (raw file):
return; rs::sendMsgPushToPlayer(other, self);
Suggestion:
if (al::isSensorName(self, "Push") && isBreak())
rs::sendMsgPushToPlayer(other, self);
github-actions
Bot
added
status:waiting for author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I heard something about the Yoshi saga?
This change is
Report for 1.0 (441aec9 - 3fc97bb)
📈 Matched code: 15.51% (+0.01%, +1604 bytes)
✅ 16 new matches
Player/YoshiEggYoshiEgg::init(al::ActorInitInfo const&)Player/YoshiEggYoshiEgg::receiveMsg(al::SensorMsg const*, al::HitSensor*, al::HitSensor*)Player/YoshiEggYoshiEgg::YoshiEgg(al::LiveActor const*, IUsePlayerCollision const*)Player/YoshiEggYoshiEgg::YoshiEgg(al::LiveActor const*, IUsePlayerCollision const*)Player/YoshiEggYoshiEgg::attackSensor(al::HitSensor*, al::HitSensor*)Player/YoshiEgg(anonymous namespace)::YoshiEggNrvAppear::execute(al::NerveKeeper*) constPlayer/YoshiEggYoshiEgg::exeAppear()Player/YoshiEgg(anonymous namespace)::YoshiEggNrvBreak::execute(al::NerveKeeper*) constPlayer/YoshiEggYoshiEgg::exeBreak()Player/YoshiEgg(anonymous namespace)::YoshiEggNrvWait::execute(al::NerveKeeper*) constPlayer/YoshiEggYoshiEgg::appearEgg()Player/YoshiEggYoshiEgg::exeWait()Player/YoshiEggYoshiEgg::initPlacementEgg()Player/YoshiEggYoshiEgg::isEndAppear() constPlayer/YoshiEggYoshiEgg::initAfterPlacement()Player/YoshiEggYoshiEgg::isBreak() const