Skip to content

Util: Finish implementing ItemUtil - #1331

Open
german77 wants to merge 2 commits into
MonsterDruide1:masterfrom
german77:ItemUtil
Open

Util: Finish implementing ItemUtil#1331
german77 wants to merge 2 commits into
MonsterDruide1:masterfrom
german77:ItemUtil

Conversation

@german77

@german77 german77 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This change is Reviewable


Report for 1.0 (441aec9 - c5d52ff)

📈 Matched code: 15.50% (+0.00%, +316 bytes)

✅ 3 new matches
Unit Item Bytes Before After
Util/ItemUtil rs::appearRandomItemFromObj(al::LiveActor*, al::HitSensor*, float) +196 0.00% 100.00%
Util/ItemUtil StageSceneFunction::appearPlayerDeadCoin(al::LiveActor*) +96 0.00% 100.00%
Util/ItemUtil rs::addDemoRacePrizeCoin(al::LiveActor*) +24 0.00% 100.00%

@github-actions github-actions Bot added the status:waiting for review This PR is ready to take the first or another look at it! label Aug 4, 2026
@MonsterDruide1 MonsterDruide1 changed the title Util: Implement remaining functions of ItemUtil Util: Finish implementing ItemUtil Aug 4, 2026

@MonsterDruide1 MonsterDruide1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 6 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on german77).


src/Scene/ProjectItemDirector.h line 23 at r1 (raw file):

    void appearItem(const char*, const sead::Vector3f&, const sead::Quatf&,
                    const al::HitSensor*) override;

Suggestion:

    al::LiveActor* appearItem(const char*, const sead::Vector3f&, const sead::Quatf&,
                    const al::HitSensor*) override;

src/Scene/ProjectItemDirector.h line 36 at r1 (raw file):

private:
};

Suggestion:

private:
  char size[...];
};
static_assert(sizeof(..) == 0x68);

@github-actions github-actions Bot added status:waiting for author Reviews have shown that the author of this PR needs to change some things. and removed status:waiting for review This PR is ready to take the first or another look at it! labels Aug 4, 2026

@german77 german77 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@german77 made 2 comments.
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on MonsterDruide1).


src/Scene/ProjectItemDirector.h line 23 at r1 (raw file):

    void appearItem(const char*, const sead::Vector3f&, const sead::Quatf&,
                    const al::HitSensor*) override;

Done.


src/Scene/ProjectItemDirector.h line 36 at r1 (raw file):

private:
};

Done.

@github-actions github-actions Bot added status:waiting for review This PR is ready to take the first or another look at it! and removed status:waiting for author Reviews have shown that the author of this PR needs to change some things. labels Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:waiting for review This PR is ready to take the first or another look at it!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants