Library/Se/Project: Implement SePlayParam - #1318
Open
c4nvm wants to merge 1 commit into
Open
Conversation
MonsterDruide1
requested changes
Jul 23, 2026
MonsterDruide1
left a comment
Owner
There was a problem hiding this comment.
@MonsterDruide1 reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on c4nvm and MonsterDruide1).
lib/al/Library/Se/Project/SePlayParam.h line 7 at r1 (raw file):
namespace al { enum class SePlayParamType {
TODO: check this
lib/al/Library/Se/Project/SePlayParam.cpp line 13 at r1 (raw file):
mValue = 1.0f; mValue2 = 0.0f; }
... and put those default values in the header.
Not sure if this matches.
Suggestion:
SePlayParam::SePlayParam() = default;
void SePlayParam::reset() {
*this = {};
}lib/al/Library/Se/Project/SePlayParam.cpp line 25 at r1 (raw file):
mType = type; mValue2 = value2; mValue = mul;
might match, not sure
Suggestion:
mType = type;
mValue *= mul;
mValue2 = value2;Library/Se/Project/SePlayParam.oSePlayParam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements all of
SePlayParam.ofor #2034. ctor,reset,set,setMul, plus the header and cpp.al::SePlayParamis a 12 byte SE param entry:SePlayParamType mType(0x0),f32 mValue(0x4, default 1.0f),f32 mValue2(0x8, default 0.0f). ctor andresetdefault to invalid/1.0/0.0,setoverwrites all three,setMulswaps type +mValue2and multipliesmValue.enum comes from the switch in
conveyParamListToHandle, which maps each type to anAcLSoundHandlesetter. that's what tells memValueis the main operand andmValue2is the secondary index for the seq variable and biquad cases. invalid(0), volume(1), pitch(2), seqTempoRatio(3), effectSend(4), seqLocalVariable(5), seqGlobalVariable(6), lpfFreq(7), biquadFilter(8).setMulneeded an explicit temp float or the multiply wouldn't match. method/class names are from mangled symbols, field and enum names are inferred so flag anything off.This change is
Report for 1.0 (ae6bf40 - 4f8b41d)
📈 Matched code: 15.32% (+0.00%, +72 bytes)
✅ 4 new matches
Library/Se/Project/SePlayParamal::SePlayParam::setMul(al::SePlayParamType, float, float)Library/Se/Project/SePlayParamal::SePlayParam::SePlayParam()Library/Se/Project/SePlayParamal::SePlayParam::reset()Library/Se/Project/SePlayParamal::SePlayParam::set(al::SePlayParamType, float, float)