Skip to content

Boss/BombTail: Implement BombTailBomb/BombTailCap pre-battle handlers and BombTailTail updates - #1284

Open
DrapNard wants to merge 4 commits into
MonsterDruide1:masterfrom
DrapNard:boss/bombtail-state-tail-methods
Open

Boss/BombTail: Implement BombTailBomb/BombTailCap pre-battle handlers and BombTailTail updates#1284
DrapNard wants to merge 4 commits into
MonsterDruide1:masterfrom
DrapNard:boss/bombtail-state-tail-methods

Conversation

@DrapNard

@DrapNard DrapNard commented Jun 22, 2026

Copy link
Copy Markdown

This change is Reviewable


Report for 1.0 (abe7639 - 7afe831)

📈 Matched code: 15.18% (+0.00%, +24 bytes)

✅ 6 new matches
Unit Item Bytes Before After
Boss/BombTail/BombTailBomb BombTailBomb::exeBeforeBattleStart() +4 0.00% 100.00%
Boss/BombTail/BombTailCap BombTailCap::exeBeforeBattleStart() +4 0.00% 100.00%
Boss/BombTail/BombTailTail BombTailTailJointCalulator::calcBounce(sead::Matrix34<float> const*, float) +4 0.00% 100.00%
Boss/BombTail/BombTailTail BombTailTail::startResetAttack() +4 0.00% 100.00%
Boss/BombTail/BombTailTailPartsModelUpdater BombTailTailPartsModelUpdater::preCalcAnim() +4 0.00% 100.00%
Boss/BombTail/BombTailTailPartsModelUpdater BombTailTailPartsModelUpdater::postEndClipped() +4 0.00% 100.00%

Copilot AI review requested due to automatic review settings June 22, 2026 09:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the status:waiting for review This PR is ready to take the first or another look at it! label Jun 22, 2026
@german77

Copy link
Copy Markdown
Contributor

I ignored this detail because it was your first PR. But normally you want to do a full implementation of a specific class and not a single random function. If you want to do headers only is fine but implementing single functions is rather slopy.

I invite you to join the discord. We can teach you the basics of RE so you can implement a full class yourself.

@MonsterDruide1 MonsterDruide1 added the ai This PR has been created with the help of AI tools and is handled with a lower priority. label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai This PR has been created with the help of AI tools and is handled with a lower priority. status:waiting for review This PR is ready to take the first or another look at it!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants