MapObj: Implement KuriboTowerSwitch - #1273
Open
Naii-the-Baf wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
status:waiting for review
Naii-the-Baf
force-pushed
the
KuriboTowerSwitch
branch
from
June 3, 2026 17:35
09a27c4 to
5dd2154
Compare
Naii-the-Baf
commented
Aug 5, 2026
Naii-the-Baf
left a comment
Naii-the-Baf
left a comment
Contributor
Author
There was a problem hiding this comment.
Bump
@Naii-the-Baf made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
github-actions
Bot
added
status:waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs names for 2 fields that I couldn't figure out exactly what they represent.
I'm a bit unclear on the type of
mNum. It doesn't compile if I make it unsigned, but it clearly should be unsigned given the return type ofrs::getNumKuriboTowerOn. I had to cast it to make the compiler stop complaining about a comparison between signed and unsigned.This change is
Report for 1.0 (a76cdfb - 5dd2154)
📈 Matched code: 15.18% (+0.02%, +2104 bytes)
✅ 17 new matches
MapObj/KuriboTowerSwitchKuriboTowerSwitch::receiveMsg(al::SensorMsg const*, al::HitSensor*, al::HitSensor*)MapObj/KuriboTowerSwitchKuriboTowerSwitch::init(al::ActorInitInfo const&)MapObj/KuriboTowerSwitchKuriboTowerSwitch::exeOn()MapObj/KuriboTowerSwitchKuriboTowerSwitch::KuriboTowerSwitch(char const*)MapObj/KuriboTowerSwitchKuriboTowerSwitch::KuriboTowerSwitch(char const*)MapObj/KuriboTowerSwitch(anonymous namespace)::KuriboTowerSwitchNrvReactionLand::execute(al::NerveKeeper*) constMapObj/KuriboTowerSwitchKuriboTowerSwitch::exeReactionLand()MapObj/KuriboTowerSwitch(anonymous namespace)::KuriboTowerSwitchNrvOnWait::execute(al::NerveKeeper*) constMapObj/KuriboTowerSwitchKuriboTowerSwitch::control()MapObj/KuriboTowerSwitchKuriboTowerSwitch::exeOnWait()MapObj/KuriboTowerSwitchKuriboTowerSwitch::isReactionNerve() constMapObj/KuriboTowerSwitch(anonymous namespace)::KuriboTowerSwitchNrvOffWait::execute(al::NerveKeeper*) constMapObj/KuriboTowerSwitch(anonymous namespace)::KuriboTowerSwitchNrvDisable::execute(al::NerveKeeper*) constMapObj/KuriboTowerSwitchKuriboTowerSwitch::exeDisable()MapObj/KuriboTowerSwitchKuriboTowerSwitch::exeOffWait()MapObj/KuriboTowerSwitchKuriboTowerSwitch::initAfterPlacement()MapObj/KuriboTowerSwitch(anonymous namespace)::KuriboTowerSwitchNrvOn::execute(al::NerveKeeper*) const