Skip to content

Update dependency MonsterDruide1/OdysseyDecompToolsCache to v1.2.5 - #1271

Open
renovate[bot] wants to merge 4 commits into
masterfrom
renovate/monsterdruide1-odysseydecomptoolscache-1.x
Open

Update dependency MonsterDruide1/OdysseyDecompToolsCache to v1.2.5#1271
renovate[bot] wants to merge 4 commits into
masterfrom
renovate/monsterdruide1-odysseydecomptoolscache-1.x

Conversation

@renovate

@renovate renovate Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Update Change
MonsterDruide1/OdysseyDecompToolsCache patch v1.2.4v1.2.5

Release Notes

MonsterDruide1/OdysseyDecompToolsCache (MonsterDruide1/OdysseyDecompToolsCache)

v1.2.5

Compare Source

What's Changed

viking changes:

  • decompme now generates a scratch with instruction offsets that match the original binary (by @​german77)
  • check now checks calls to functions that haven't been implemented yet (by @​MonsterDruide1)
    (Both features where ported from the upstream repo by @​LynxDev2)

Full Changelog: MonsterDruide1/OdysseyDecompToolsCache@v1.2.4...v1.2.5


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.


This change is Reviewable


Report for 1.0 (5fcb6d9 - 497d50c)

No changes

@github-actions github-actions Bot added the status:waiting for review This PR is ready to take the first or another look at it! label Jun 2, 2026
@LynxDev2

LynxDev2 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Not sure what's going on with the workflow fails. I thought that nx2elf accidentally got updated and it was causing the errors (since the latest nx2elf version doesn't work without changes to upstream nx-decomp-tools iirc) but it works completely fine when testing locally

@LynxDev2

LynxDev2 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Apparently nx2elf did actually get updated (which is a good thing, in a way), so this PR is now blocked by open-ead/nx-decomp-tools#45

@renovate renovate Bot changed the title chore(deps): update dependency monsterdruide1/odysseydecomptoolscache to v1.2.5 Update dependency MonsterDruide1/OdysseyDecompToolsCache to v1.2.5 Jun 19, 2026
@renovate

renovate Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@MonsterDruide1
MonsterDruide1 force-pushed the renovate/monsterdruide1-odysseydecomptoolscache-1.x branch from 97f2bb3 to 497d50c Compare June 22, 2026 23:07
@LynxDev2

Copy link
Copy Markdown
Contributor

You still need to add the change to tools/config.toml

@MonsterDruide1

Copy link
Copy Markdown
Owner

You mean fully disabling check_unimplemented_references?
We have all of them fixed, apart from the C1/D1 issues. So a new tools release should fix everything without needing to temporarily disable the check.

@LynxDev2

Copy link
Copy Markdown
Contributor

I thought we discussed on discord that it can be temporarily disabled and then enabled again after the next release? I don’t think a new tools cache release should be a blocker for the other new features added in this release as I want to wait a bit before doing one

@MonsterDruide1

Copy link
Copy Markdown
Owner

We discussed the disabling as part of a temporary workaround until all issues have been fixed, but @german77 has been strong at working through all of those - so only the C1/D1 ones remain, which afaik have been fixed on your fork, so we just need a new tools release that I can then merge into this PR to get the new check working and running immediately, instead of keeping it dormant and then possibly requiring more fixes to get it back working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:waiting for review This PR is ready to take the first or another look at it!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants