Item: Implement YoshiFruitShineHolder - #1266
Conversation
YoshiFruitShineHolder
MonsterDruide1
left a comment
There was a problem hiding this comment.
@MonsterDruide1 reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on nicholasyoannou).
src/Item/YoshiFruitShineHolder.h line 21 at r1 (raw file):
void init(const al::ActorInitInfo& info) override; void updateHintPos(const sead::Vector3f& pos); al::LiveActor* appearShineFromFruit(const sead::Vector3f& pos);
be as specific as it makes sense for the return type - there's no reason to not pick Shine here, so go with that one.
Suggestion:
Shine* appearShineFromFruit(const sead::Vector3f& pos);src/Item/YoshiFruitShineHolder.h line 32 at r1 (raw file):
namespace rs { void registerFruitShineHolder(YoshiFruitShineHolder*); } // namespace rs
declare this in the correct file, then #include it in the .cpp file
|
Done |
MonsterDruide1
left a comment
There was a problem hiding this comment.
@MonsterDruide1 reviewed 2 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on nicholasyoannou).
src/Util/ItemUtil.h at r2 (raw file):
No, according to file_list.yml, it should be placed in src/Item/YoshiFruitWatcher.h.
Closes MonsterDruide1/OdysseyDecompTracker#475
This change is
Report for 1.0 (c889da8 - 0a0edf8)
📈 Matched code: 15.17% (+0.01%, +660 bytes)
✅ 5 new matches
Item/YoshiFruitShineHolderYoshiFruitShineHolder::init(al::ActorInitInfo const&)Item/YoshiFruitShineHolderYoshiFruitShineHolder::YoshiFruitShineHolder(char const*)Item/YoshiFruitShineHolderYoshiFruitShineHolder::YoshiFruitShineHolder(char const*)Item/YoshiFruitShineHolderYoshiFruitShineHolder::appearShineFromFruit(sead::Vector3<float> const&)Item/YoshiFruitShineHolderYoshiFruitShineHolder::updateHintPos(sead::Vector3<float> const&)