Skip to content

Item: Implement YoshiFruitShineHolder - #1266

Open
nicholasyoannou wants to merge 2 commits into
MonsterDruide1:masterfrom
nicholasyoannou:YoshiFruitShineHolder
Open

Item: Implement YoshiFruitShineHolder#1266
nicholasyoannou wants to merge 2 commits into
MonsterDruide1:masterfrom
nicholasyoannou:YoshiFruitShineHolder

Conversation

@nicholasyoannou

@nicholasyoannou nicholasyoannou commented May 28, 2026

Copy link
Copy Markdown
Contributor

Closes MonsterDruide1/OdysseyDecompTracker#475


This change is Reviewable


Report for 1.0 (c889da8 - 0a0edf8)

📈 Matched code: 15.17% (+0.01%, +660 bytes)

✅ 5 new matches
Unit Item Bytes Before After
Item/YoshiFruitShineHolder YoshiFruitShineHolder::init(al::ActorInitInfo const&) +228 0.00% 100.00%
Item/YoshiFruitShineHolder YoshiFruitShineHolder::YoshiFruitShineHolder(char const*) +140 0.00% 100.00%
Item/YoshiFruitShineHolder YoshiFruitShineHolder::YoshiFruitShineHolder(char const*) +128 0.00% 100.00%
Item/YoshiFruitShineHolder YoshiFruitShineHolder::appearShineFromFruit(sead::Vector3<float> const&) +92 0.00% 100.00%
Item/YoshiFruitShineHolder YoshiFruitShineHolder::updateHintPos(sead::Vector3<float> const&) +72 0.00% 100.00%

@github-actions github-actions Bot added the status:waiting for review This PR is ready to take the first or another look at it! label May 28, 2026
@nicholasyoannou nicholasyoannou changed the title Item: Implement Item: Implement YoshiFruitShineHolder May 28, 2026

@MonsterDruide1 MonsterDruide1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on nicholasyoannou).


src/Item/YoshiFruitShineHolder.h line 21 at r1 (raw file):

    void init(const al::ActorInitInfo& info) override;
    void updateHintPos(const sead::Vector3f& pos);
    al::LiveActor* appearShineFromFruit(const sead::Vector3f& pos);

be as specific as it makes sense for the return type - there's no reason to not pick Shine here, so go with that one.

Suggestion:

Shine* appearShineFromFruit(const sead::Vector3f& pos);

src/Item/YoshiFruitShineHolder.h line 32 at r1 (raw file):

namespace rs {
void registerFruitShineHolder(YoshiFruitShineHolder*);
}  // namespace rs

declare this in the correct file, then #include it in the .cpp file

@github-actions github-actions Bot added status:waiting for author Reviews have shown that the author of this PR needs to change some things. and removed status:waiting for review This PR is ready to take the first or another look at it! labels May 28, 2026
@nicholasyoannou

Copy link
Copy Markdown
Contributor Author

Done

@MonsterDruide1 MonsterDruide1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 2 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on nicholasyoannou).


src/Util/ItemUtil.h at r2 (raw file):
No, according to file_list.yml, it should be placed in src/Item/YoshiFruitWatcher.h.

@github-actions github-actions Bot added status:waiting for author Reviews have shown that the author of this PR needs to change some things. and removed status:waiting for author Reviews have shown that the author of this PR needs to change some things. labels May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:waiting for author Reviews have shown that the author of this PR needs to change some things.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Item/YoshiFruitShineHolder.o

2 participants