Skip to content

Audio: Implement ProjectSeNamedList - #1259

Open
nicholasyoannou wants to merge 1 commit into
MonsterDruide1:masterfrom
nicholasyoannou:ProjectSeNamedList
Open

Audio: Implement ProjectSeNamedList#1259
nicholasyoannou wants to merge 1 commit into
MonsterDruide1:masterfrom
nicholasyoannou:ProjectSeNamedList

Conversation

@nicholasyoannou

@nicholasyoannou nicholasyoannou commented May 25, 2026

Copy link
Copy Markdown
Contributor

Closes MonsterDruide1/OdysseyDecompTracker#23


This change is Reviewable


Report for 1.0 (9f787bc - 072ad41)

📈 Matched code: 15.14% (+0.00%, +24 bytes)

✅ 3 new matches
Unit Item Bytes Before After
Audio/ProjectSeNamedList ProjectSeNamedList::getMuteSeInPVList() +12 0.00% 100.00%
Audio/ProjectSeNamedList ProjectSeNamedList::getMuteSeInPVListSize() +8 0.00% 100.00%
Audio/ProjectSeNamedList ProjectSeNamedList::ProjectSeNamedList() +4 0.00% 100.00%

@github-actions github-actions Bot added the status:waiting for review This PR is ready to take the first or another look at it! label May 25, 2026

@german77 german77 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@german77 made 2 comments.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on nicholasyoannou).


src/Audio/ProjectSeNamedList.cpp line 3 at r1 (raw file):

#include "Audio/ProjectSeNamedList.h"

static const char* const sMuteSeInPVList[] = {

Suggestion:

static const char* const sMuteSeInPVList[22] = {

src/Audio/ProjectSeNamedList.cpp line 31 at r1 (raw file):

s32 ProjectSeNamedList::getMuteSeInPVListSize() {
    return 0x16;

Suggestion:

    return 22;

@github-actions github-actions Bot added status:waiting for author Reviews have shown that the author of this PR needs to change some things. and removed status:waiting for review This PR is ready to take the first or another look at it! labels Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:waiting for author Reviews have shown that the author of this PR needs to change some things.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Audio/ProjectSeNamedList.o

2 participants