Audio: Implement ProjectSeNamedList - #1259
Open
nicholasyoannou wants to merge 1 commit into
Open
Conversation
german77
reviewed
Aug 11, 2026
german77
left a comment
Contributor
There was a problem hiding this comment.
@german77 made 2 comments.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on nicholasyoannou).
src/Audio/ProjectSeNamedList.cpp line 3 at r1 (raw file):
#include "Audio/ProjectSeNamedList.h" static const char* const sMuteSeInPVList[] = {
Suggestion:
static const char* const sMuteSeInPVList[22] = {src/Audio/ProjectSeNamedList.cpp line 31 at r1 (raw file):
s32 ProjectSeNamedList::getMuteSeInPVListSize() { return 0x16;
Suggestion:
return 22;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MonsterDruide1/OdysseyDecompTracker#23
This change is
Report for 1.0 (9f787bc - 072ad41)
📈 Matched code: 15.14% (+0.00%, +24 bytes)
✅ 3 new matches
Audio/ProjectSeNamedListProjectSeNamedList::getMuteSeInPVList()Audio/ProjectSeNamedListProjectSeNamedList::getMuteSeInPVListSize()Audio/ProjectSeNamedListProjectSeNamedList::ProjectSeNamedList()