Library/Item: Implement ActorItemInfo

[nicholasyoannou]

Closes MonsterDruide1/OdysseyDecompTracker#2234

---

This change is 

---

Report for 1.0 (9f787bc - 79fb237)

📈 Matched code: 15.15% (+0.00%, +96 bytes)

✅ 3 new matches

Unit	Item	Bytes	Before	After
Unknown/ActorItemInfo	al::ActorItemInfo::isEqualTiming(char const*) const	+40	0.00%	100.00%
Unknown/ActorItemInfo	al::ActorItemInfo::isEqualFactor(char const*) const	+40	0.00%	100.00%
Unknown/ActorItemInfo	al::ActorItemInfo::ActorItemInfo(char const*, char const*, char const*, int)	+16	0.00%	100.00%

[german77]

@german77 made 3 comments.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on nicholasyoannou).

---

lib/al/Library/Item/ActorItemInfo.cpp line 13 at r1 (raw file):

    _18 = 0;
    mValue = value;
}

_18 is initialized in the header

Suggestion:

ActorItemInfo::ActorItemInfo(const char* name, const char* timing, const char* factor, s32 value):mName(name),mTimin(timing),mFactor(factor),mValue(value) {
}

---

lib/al/Library/Item/ActorItemInfo.cpp line 18 at r1 (raw file):

    if (timing != nullptr && mTiming != nullptr)
        return isEqualString(timing, mTiming);
    return timing == nullptr && mTiming == nullptr;

Suggestion:

    if (!timing || !mTiming)
        return !timing && !mTiming;
    
    return isEqualString(timing, mTiming);

---

lib/al/Library/Item/ActorItemInfo.cpp line 24 at r1 (raw file):

    if (factor != nullptr && mFactor != nullptr)
        return isEqualString(factor, mFactor);
    return factor == nullptr && mFactor == nullptr;

Suggestion:

    if (!factor || !mFactor)
        return !factor && !mFactor;
    return isEqualString(factor, mFactor);