Player: Implement YoshiStateEgg - #1183
Open
guymakinggames wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
status:waiting for review
MonsterDruide1
added
the
ai
german77
reviewed
May 10, 2026
german77
left a comment
german77
left a comment
Contributor
There was a problem hiding this comment.
@german77 made 1 comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on guymakinggames).
src/Player/YoshiStateEgg.cpp line 84 at r1 (raw file):
gravityValue * gravity.z}; al::tryAddVelocityLimit(actor, velocity, playerConst->getFallSpeedMax()); }
Suggestion:
al::tryAddVelocityLimit(actor, al::getGravity(actor)*playerConst->getGravity(), playerConst->getFallSpeedMax());
}
github-actions
Bot
added
status:waiting for author
guymakinggames
force-pushed
the
YoshiStateEgg
branch
from
May 22, 2026 18:18
6163b66 to
059d7a4
Compare
guymakinggames
commented
May 22, 2026
guymakinggames
left a comment
guymakinggames
left a comment
Contributor
Author
There was a problem hiding this comment.
@guymakinggames made 1 comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on german77).
src/Player/YoshiStateEgg.cpp line 84 at r1 (raw file):
gravityValue * gravity.z}; al::tryAddVelocityLimit(actor, velocity, playerConst->getFallSpeedMax()); }
Done.
github-actions
Bot
added
status:waiting for review
guymakinggames
force-pushed
the
YoshiStateEgg
branch
from
May 22, 2026 18:22
059d7a4 to
7f959c5
Compare
Contributor
|
Superseded by #1333 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is
Report for 1.0 (c4d724d - 7f959c5)
📈 Matched code: 15.14% (+0.01%, +1124 bytes)
✅ 10 new matches
Player/YoshiStateEgg(anonymous namespace)::updateEggMove(al::LiveActor*, IUsePlayerCollision const*, PlayerConst const*)Player/YoshiStateEggYoshiStateEgg::YoshiStateEgg(al::ActorInitInfo const&, al::LiveActor*, IUsePlayerCollision const*, PlayerConst const*, al::WaterSurfaceFinder const*, PlayerModelChangerYoshi*)Player/YoshiStateEggYoshiStateEgg::reactionCollidedCollisionCode()Player/YoshiStateEggYoshiStateEgg::appear()Player/YoshiStateEgg(anonymous namespace)::YoshiStateEggNrvWait::execute(al::NerveKeeper*) constPlayer/YoshiStateEggYoshiStateEgg::exeWait()Player/YoshiStateEgg(anonymous namespace)::YoshiStateEggNrvAppear::execute(al::NerveKeeper*) constPlayer/YoshiStateEggYoshiStateEgg::exeAppear()Player/YoshiStateEggYoshiStateEgg::~YoshiStateEgg()Player/YoshiStateEggYoshiStateEgg::kill()