Accesses, Internal Names and IDs, Localization and Suffering Beyond Recognition. The PR, the Game.#4269
Open
EldritchPineapple wants to merge 59 commits into
Conversation
…accesses on their own and not security
monolith8319
changed the title
EldritchPineapple
changed the title
monolith8319
changed the title
Contributor
Contributor
Author
|
i hate this i hate this i hate this i hate frontier i hope they burn and die i hate whoever ported the frontier stuff to tsf and pdv i hate it i hope you die |
Contributor
Author
|
ZALL MERGED DO IT PLEAAAAAAAAAASE |
Contributor
Author
|
*ALL TESTS PASS MERGE IT |
Contributor
Author
|
if i'm missing comments on important parts of the code notify me please. |
EldritchPineapple
changed the title
monolith8319
changed the title
…ffering-beyond-recognition
Contributor
Author
|
surprisingly enough the testfail is not related to me touching the code |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
Author
|
fah |
EldritchPineapple
force-pushed
the
accesse,-internal-names,-localization-and-suffering-beyond-recognition
branch
from
July 18, 2026 11:22
6410491 to
37ae808
Compare
…ond-recognition' of https://github.com/EldritchPineapple/Monolith into accesse,-internal-names,-localization-and-suffering-beyond-recognition
Contributor
Author
|
MAP PROTO TESTFAIL IS NOT ME RELATED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
revamped all access levels for tsf and factions because it was frontierslop
moved a lot of mono specific things that were still in the frontier directory because of laziness, as it was mono original content
Why / Balance
I was very mad that the tsfcolonel was the HoS and had basically AA on everything, + a lot of things has old nfsd stamps on them for no reason, same as pdv being pirate related
Media
fuck no it's all in files changed
Requirements
How to test
load the game, watch as accesses work (HOPEFULLY) and names are less nonsensical
Breaking changes
it might fuck a few things concerning some playtime trackers as i've simply nuked some roles and replaced them elsewhere, tell me if the job ids i removed from the Security department have caused your playtime in tsf to decrease
chatranks and silicons will have to be reset because i can't fit an OR component to their time requirement, meaning you will have to redo faction hours to unlock chatranks and AI roles, sorry
if you have any ship or map PR or changes to shipyard files, please correct the job ids in the shipyard file and spawnpoints in the grid file to the now correctly named versions
Changelog
🆑