Add the xTB backends to environment.yml - #72
Merged
Conversation
The Conda environment already installed DFTB+; add the xTB engines' backends so `conda env create -f environment.yml` provisions every calculation engine: - xtb -- the native binary for `--engine xtb-cli` - tblite-python -- GFN-xTB via tblite for `--engine xtb` Also note in the README that the environment now covers all backends and that `thermo doctor` should then report them all as found.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 24 24
Lines 1527 1527
=======================================
Hits 1476 1476
Misses 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
environment.ymlalready installed DFTB+ but predates the xTB engines (#68, #70). Add the xTB backends soconda env create -f environment.ymlprovisions every calculation engine in one command.After
conda env create -f environment.yml && conda activate thermoscreening,thermo doctorreports every backend as found (pairs with #71). README updated to say the env covers all backends.Verified the three backends resolve on conda-forge (dftbplus-25.1 nompi, xtb-6.6.1, tblite-python-0.3.0); YAML validated.
This is the "installable through the project" follow-up: the compiled backends (DFTB+/modes/xtb/tblite) can't be pip-installed, so the conda env is how the project bundles them, while
thermo setup-dftbhandles the Slater-Koster and GBSA parameter files.